Skip to content

fix tests on nightly #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengj merged 2 commits into from
Jun 11, 2026
Merged

fix tests on nightly #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
029ef1e
fix tests on nightly
stevengj Jun 11, 2026
313093e
SVRegexMatch fixes
stevengj Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
using Test
using StringViews: StringViews, StringView, SVRegexMatch

# DenseStringView is not public, used only for tests
if isdefined(Base, :DenseStringView)
using Base: DenseStringView
else
using StringViews: DenseStringView
end

b = Vector{UInt8}("foobar")
s = StringView(b)
ss = SubString(s, 2, 5) # "ooba"
Expand All @@ -23,10 +30,10 @@ su = stringview("föôẞαr")

@test stringview("foo") isa StringView{Base.CodeUnits{UInt8,String}}

@test s isa StringViews.DenseStringView
@test StringView(@view b[1:3]) isa StringViews.DenseStringView
@test stringview("foo") isa StringViews.DenseStringView
@test StringView(@view codeunits("foobar")[1:3]) isa StringViews.DenseStringView
@test s isa DenseStringView
@test StringView(@view b[1:3]) isa DenseStringView
@test stringview("foo") isa DenseStringView
@test StringView(@view codeunits("foobar")[1:3]) isa DenseStringView

@test pointer(s) == pointer(b) == Base.unsafe_convert(Ptr{UInt8}, s)
@test Base.unsafe_convert(Ptr{Int8}, s) == Ptr{Int8}(pointer(s))
Expand Down Expand Up @@ -86,7 +93,7 @@ end

sv = stringview("foo 1234 bar")
@test match(r"[0-9]+", sv).match.string === sv
@test eltype(eachmatch(r"[0-9]+", sv)) == SVRegexMatch{typeof(sv)}
@test eltype(eachmatch(r"[0-9]+", sv)) <: SVRegexMatch

# Regex match of substring of stringview
strv = only(match(r"^([a-z]+)$", SubString(StringView(b"abc"))))
Expand All @@ -100,7 +107,7 @@ end
@test haskey(m, "b")
@test !haskey(m, "foo")
@test (m[:a], m[2], m["b"]) == ("x", "y", "z")
@test sprint(show, m) == "SVRegexMatch(\"xyz\", a=\"x\", 2=\"y\", b=\"z\")"
@test sprint(show, m) == "$SVRegexMatch(\"xyz\", a=\"x\", 2=\"y\", b=\"z\")"
@test keys(m) == ["a", 2, "b"]
end

Expand Down
Loading