Manual ruff fixes#6
Conversation
|
Hi! I completely forgot this PR! Sorry... I hope it's not a problem for you. I realized while reviewing this module that it was wrong. I focused in the window area functionality (which is the one used by PyWinCtl) but not much in the screen area one. When using the module for screen areas (similar to PyGame.Rect object), it was confusing and hard to properly use. Since I had to update it to imprve it anyway, I took the opportunity to include other additional methods that I left unuploaded about 2 years ago, as well as improving the docs. However, I am not generating a new version on PyPi yet, since I have to fully test everything first. Again, I hope it's not a problem. If it is, please let me know what can I do to help. |
|
No problem, take your time. Always a good thing if the recent wave of changes and reviews made you realize things to improve :) The main big improvements I'm going for right now that will be useful to me are:
|
|
Awesome! You are totally right that this new wave is really a boost, since one can look same things with new eyes. I have (hopefully) improved all modules docs. I am also working in your suggestions for PyWinCtl (as well as adapting it to this new PyWinBox version). This will take me longer, since I have to test everything, though my environment is... well, not prepared as it was, let's say. Thanks! |
|
Sorry. Your last checks for this PR failed because of a mistake of mine (not typing self._clamp variable, no more and no less). I am not touching anything else until you finish this PR!!! Promissed... XD |
|
Hi! Sorry to use this way to contact you (I don't know how to do it otherwise). I've trying to properly type
Thanks for your help! |
|
Just as a quick context before my answer: So yes, using As long as you string-quote your annotations, the symbols won't be evaluated at runtime # Ambiguous alias, type checkers may not be happy or think this is a value assignement
SomethingParam = Sequence[str]# TypeAlias gets evaluated, breaks because the symbol isn't imported at runtime
SomethingParam: TypeAlias = Sequence[str]# TypeAlias doesn't get evaluated
SomethingParam: "TypeAlias" = Sequence[str]from __future__ import annotations
# TypeAlias doesn't get evaluated, because all annotations in this file are auto-quoted
SomethingParam: TypeAlias = Sequence[str]# Python 3.12+ syntax
type SomethingParam = Sequence[str]Btw, if you ever want me to validate some code, you can open a PR and request me as a reviewer, makes it easy to show the changes and comment on specific lines. |
Uh oh!
There was an error while loading. Please reload this page.