Skip to content

KC-1307, KC-1308, KC-1309 & KC-1310: Fix: nsf share expiration updates, rename Supershell Drive folder labels, and standardize list command's record_category#2155

Merged
sk-keeper merged 1 commit into
releasefrom
nsf-share-command-and-nsf-rename-fixes
Jun 16, 2026
Merged

KC-1307, KC-1308, KC-1309 & KC-1310: Fix: nsf share expiration updates, rename Supershell Drive folder labels, and standardize list command's record_category#2155
sk-keeper merged 1 commit into
releasefrom
nsf-share-command-and-nsf-rename-fixes

Conversation

@sshrushanth-ks

Copy link
Copy Markdown
Contributor

Summary

Fixed expiration updates for nsf-share-folder and nsf-share-record, enforced a one-minute minimum on NSF and classic share commands, standardized list/search record_category to classic/nested, and renamed Supershell Drive folder labels to Nested Shared Folder (Shared) and (NonShared).

Changes

  • Fixed nsf-share-folder not updating expiration on existing shares by adding expiration_timestamp to update_folder_access_v3 and passing it through from grant_folder_access_v3
  • Fixed already_had_access and never (-1) handling so same-role expiration updates and clear-expiration requests worked correctly
  • Fixed nsf-share-record expiration updates by revoking and re-granting sequentially, since the server only inserts expiration rows on create
  • Reduced redundant syncs during record share updates, added revoke/re-grant progress logging, and skipped no-op updates when role and expiration already matched
  • Fixed reading tla_expiration from access details after an invalid proto3 HasField check caused existing shares to be treated as new grants
  • Enforced a one-minute minimum share expiration on nsf-share-record, nsf-share-folder, share-record, and share-folder
  • Added unit tests for folder/record expiration updates, sub-minute rejection, revoke-and-recreate, and access-detail parsing
  • Standardized list/search record_category from Classic/Nested to lowercase classic/nested
  • Renamed Supershell folder icon labels to Nested Shared Folder (Shared) and Nested Shared Folder (NonShared)

…, rename Supershell Drive folder labels, and standardize list record_category

Fixed nsf-share-folder and nsf-share-record expiration updates, enforced a
one-minute minimum on NSF and classic share commands, standardized list/search
record_category to lowercase classic/nested, and renamed Supershell Drive
folder labels to Nested Shared Folder (Shared) and (NonShared).
@sshrushanth-ks sshrushanth-ks marked this pull request as ready for review June 16, 2026 09:30
@sshrushanth-ks sshrushanth-ks self-assigned this Jun 16, 2026
@sk-keeper sk-keeper merged commit 2a81177 into release Jun 16, 2026
4 checks passed
@sk-keeper sk-keeper deleted the nsf-share-command-and-nsf-rename-fixes branch June 16, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants