perf(camera): use getViewMatrix output parameter to avoid copy#3549
Merged
finetjul merged 3 commits intoJul 13, 2026
Conversation
By providing the expected output array, one can avoid an array copy
Avoids getViewMatrix using the module-private tmpMatrix as scratch and also lets callers pass that same tmpMatrix in as the output buffer, which required a `result != tmpMatrix` guard and a "out can be tmpMatrix" caveat.
Collaborator
|
Looks good. Little followup to avoid extra matrix copy finetjul#3 and fix behavior.js formating |
perf(camera): build view matrix directly into out buffer
|
🎉 This PR is included in version 36.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By providing the expected output array, one can avoid an array copy
Context
Following #3544, we can improve the usage of getViewMatrix
Results
Some functions will get faster.
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting