Skip to content

Implement next-steps recommendations: dedup, tests, wiring, docs, pla… - #338

Merged
Krilliac merged 1 commit into
Workingfrom
claude/next-steps-recommendations-vBS7q
Apr 1, 2026
Merged

Implement next-steps recommendations: dedup, tests, wiring, docs, pla…#338
Krilliac merged 1 commit into
Workingfrom
claude/next-steps-recommendations-vBS7q

Conversation

@Krilliac

@Krilliac Krilliac commented Apr 1, 2026

Copy link
Copy Markdown
Owner

…ceholders, Linux screenshots

  • Refactor MaterialSystem.cpp: extract shared platform-independent code, eliminate Windows/Linux code duplication (~600 lines removed)
  • Add 4 new test suites (100+ tests): ECS specialized systems, NetworkManager edge cases, MaterialSystem edge cases, EngineSettings boundary validation
  • Wire AudioMixer singleton into engine lifecycle (Initialize + Update)
  • Add Linux screenshot support via stb_image_write in GraphicsStateAndSettings
  • Replace 5 editor panel placeholders with proper ImGui implementations (SceneView grid, SpriteEditor preview, WeaponEditor wireframe, MaterialEditor texture selector, BuildCook asset list)
  • Write 3 documentation specs: networking wire format, asset format, plugin ABI stability guide
  • All 2995 tests pass, builds clean on GCC

https://claude.ai/code/session_01Su9FT7oq9c4vEBRMn9NAws

…ceholders, Linux screenshots

- Refactor MaterialSystem.cpp: extract shared platform-independent code,
  eliminate Windows/Linux code duplication (~600 lines removed)
- Add 4 new test suites (100+ tests): ECS specialized systems, NetworkManager
  edge cases, MaterialSystem edge cases, EngineSettings boundary validation
- Wire AudioMixer singleton into engine lifecycle (Initialize + Update)
- Add Linux screenshot support via stb_image_write in GraphicsStateAndSettings
- Replace 5 editor panel placeholders with proper ImGui implementations
  (SceneView grid, SpriteEditor preview, WeaponEditor wireframe,
  MaterialEditor texture selector, BuildCook asset list)
- Write 3 documentation specs: networking wire format, asset format,
  plugin ABI stability guide
- All 2995 tests pass, builds clean on GCC

https://claude.ai/code/session_01Su9FT7oq9c4vEBRMn9NAws
@Krilliac
Krilliac merged commit d30f1cc into Working Apr 1, 2026
43 of 44 checks passed
@Krilliac
Krilliac deleted the claude/next-steps-recommendations-vBS7q branch April 1, 2026 05:05
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/JsonUtils.h                         |    -      0|    -     0|    -      0
Utils/LocalFileCache.h                    |12.7%    157| 0.0%    20|    -      0
Utils/Logger.cpp                          |21.8%    133| 0.0%    17|    -      0
Utils/Logger.h                            |18.2%    121| 0.0%    20|    -      0
Utils/MathUtils.cpp                       |    -      0|    -     0|    -      0
Utils/MemoryDebugger.h                    |13.3%    150| 0.0%    20|    -      0
Utils/MemoryMonitor.cpp                   | 9.6%    229| 0.0%    19|    -      0
Utils/MemoryMonitor.h                     |85.7%     14| 0.0%    12|    -      0
Utils/OpaqueHandle.h                      | 209%     11| 0.0%    15|    -      0
Utils/Profiler.cpp                        |14.2%    113| 0.0%    15|    -      0
Utils/Profiler.h                          |28.6%     42| 0.0%    12|    -      0
Utils/RandomEngine.h                      |29.3%     41| 0.0%    12|    -      0
Utils/Result.h                            | 100%     29| 0.0%    28|    -      0
Utils/RingBuffer.h                        | 108%     59| 0.0%    64|    -      0
Utils/ScopeGuard.h                        | 142%     36| 0.0%    51|    -      0
Utils/ScopedTimer.h                       |25.0%     12| 0.0%     3|    -      0
Utils/Serializer.h                        | 100%     48| 0.0%    42|    -      0
Utils/SparkConsole.cpp                    | 125%     32| 0.0%     6|    -      0
Utils/SparkConsole.h                      | 100%      2| 0.0%     2|    -      0
Utils/SparkError.h                        |10.9%     55| 0.0%     6|    -      0
Utils/SplinePath.h                        |    -      0|    -     0|    -      0
Utils/StackTrace.h                        |11.0%     73| 0.0%     8|    -      0
Utils/StateMachine.h                      |54.0%     63| 0.0%    32|    -      0
Utils/StringUtils.h                       |18.8%    112| 0.0%    21|    -      0
Utils/ThreadDebugger.h                    |12.8%    148| 0.0%    19|    -      0
Utils/ThreadSafeQueue.h                   |27.5%     40| 0.0%    11|    -      0
Utils/UUID.h                              |43.2%     37| 0.0%    16|    -      0
Utils/Validate.h                          |    -      0|    -     0|    -      0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                          |6700%      1| 0.0%     1|    -      0
Version.h                                 |    -      0|    -     0|    -      0
================================================================================
                                    Total:|34.4%  12115| 0.0%  2476|    -      0

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: windows-vs2022-Release
Errors: 0 | Test failures: 3 | Warnings: 2

Test Failures

Test Jobs
1/1 Test #1: SparkEngineTests .................***Failed 8.82 sec windows-vs2022-Release
[ FAILED ] Monitor_TweenSustainedLoad (352us, 5 assertions) windows-vs2022-Release
0% tests passed, 1 tests failed out of 1 windows-vs2022-Release
Compiler Warnings (2)
Source\Graphics\FogSystem.h(139): warning C4756: overflow in constant arithmetic [build\Tests\SparkTests.vcxproj]
SparkEditor\Source\Panels\InspectorComponentRenderers_Gameplay.cpp(117,17): warning C4477: 'snprintf' : format string '%u' requires an argument of type 'unsigned int', but variadic argument 1 has type 'SparkEditor::ObjectID' [build\SparkEditor\SparkEditor.vcxproj]

Updated: 2026-04-01T05:27:50Z — this comment is updated in-place, not duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants