Skip to content

Disallow mutating SQL in GET requests#7791

Open
labkey-adam wants to merge 6 commits into
developfrom
fb_mutating_sql
Open

Disallow mutating SQL in GET requests#7791
labkey-adam wants to merge 6 commits into
developfrom
fb_mutating_sql

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Rationale

For a long time (since 2019?) we've prohibited mutating SQL (INSERT, UPDATE, DELETE, etc.) via GET requests when running in dev mode with asserts on. It's past time to turn this on for production-mode deployments. This protects our customers from Cross-Site Request Forgery (CSRF) attacks. A deprecated feature flag can be enabled to turns this off temporarily in case a customer discovers a mutating action that isn't hasn't been migrated to POST. https://github.com/LabKey/kanban/issues/1941

Related Pull Requests

User Education

  • Probably need a Release Note bullet about the change in behavior. Could lump this with other security "benefits".
  • Could document the Deprecated Feature in the usual way. Although it's a little different in that we've added a flag that turns off a new feature.

Tasks 📍

  • Claude Code Review
  • Test Automation
  • Manual Testing / Verify Fix @labkey-tchad

Comment thread api/src/org/labkey/api/action/SpringActionController.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants