Skip to content

Add SigninPage#3041

Merged
labkey-alan merged 13 commits into
developfrom
fb_eln_signing
Jun 24, 2026
Merged

Add SigninPage#3041
labkey-alan merged 13 commits into
developfrom
fb_eln_signing

Conversation

@labkey-alan

@labkey-alan labkey-alan commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Rationale

This PR adds a new page, SignInPage, so we can more easily reauthenticate when submitting and approving Notebooks.

Related Pull Requests

Changes

  • Add SignInPage
  • LabKeySiteWrapper: Use SignInPage

Tasks 📍

  • Claude Code Review
  • TeamCity verification

@labkey-tchad labkey-tchad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one nit.

Comment thread src/org/labkey/test/pages/core/login/SignInPage.java Outdated
@labkey-adam labkey-adam self-requested a review June 23, 2026 20:06
labkey-alan added a commit to LabKey/labkey-ui-components that referenced this pull request Jun 24, 2026
#### Rationale
This PR adds the new getAuthenticationConfiguration API to the
SecurityAPIWrapper

#### Related Pull Requests
- LabKey/platform#7732
- LabKey/premiumModules#598
- #2016
- LabKey/labkey-ui-premium#967
- LabKey/limsModules#2250
- LabKey/testAutomation#3041

#### Changes
- panel.scss: disable margin on h1, h2, etc elements within
panel-heading components
- this made panel headings look bad in many cases (e.g. notebook review
panel)
- SecurityAPIWrapper: Add getAuthenticationConfiguration
@labkey-alan labkey-alan merged commit 4a9bb80 into develop Jun 24, 2026
6 of 7 checks passed
@labkey-alan labkey-alan deleted the fb_eln_signing branch June 24, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants