Skip to content

feat: add QSmallFaceExtra message for enhanced face data representation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Redmomn merged 2 commits into from
Mar 10, 2026
Merged

feat: add QSmallFaceExtra message for enhanced face data representation #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb737a
feat: add QSmallFaceExtra message for enhanced face data representation
Redmomn Mar 10, 2026
20df5dd
fix: make fields in QSmallFaceExtra optional for better flexibility
Redmomn Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions proto/message/v2/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,12 @@ message FaceExtra {
optional int32 face_id = 1;
}

message QSmallFaceExtra {
optional uint32 face_id = 1;
optional string preview = 2;
optional string preview2 = 3;
Comment on lines +601 to +603

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v2 proto file uses proto2 syntax (line 1), which requires every field to have an explicit label (optional, required, or repeated). All other messages in this file consistently use optional for scalar fields (e.g., FaceExtra at line 597, QFaceExtra at lines 607–616). The three fields here are missing the optional label, which makes them invalid proto2 and inconsistent with the rest of the file.

It looks like these fields were copied verbatim from proto/message/v1/element.proto (which uses proto3 syntax where labels are implicit). Please add optional to all three fields to match the v2 file conventions.

Copilot uses AI. Check for mistakes.
}

message QFaceExtra {
optional string pack_id = 1;
optional string sticker_id = 2;
Expand Down