Vismach: Merge functions from twp-vismach.py - #4370
Open
Sigma1912 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Is this something re should add to qt vismach too? |
Contributor
Author
|
Not sure. Maybe we should find a way for qtvismach to use the functions in vismach.py. |
grandixximo
requested changes
Aug 11, 2026
Sigma1912
force-pushed
the
Vismach_Add-functions
branch
from
August 11, 2026 15:36
b36c8f2 to
749758b
Compare
Contributor
Author
|
@grandixximo |
Sigma1912
marked this pull request as draft
August 11, 2026 17:12
Sigma1912
force-pushed
the
Vismach_Add-functions
branch
from
August 11, 2026 17:28
749758b to
478e2b6
Compare
Sigma1912
marked this pull request as ready for review
August 11, 2026 17:30
grandixximo
self-requested a review
August 12, 2026 01:30
grandixximo
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the added functionality in 'twp_vismach.py' to the standard 'vismach.py'
Thus the two vismach models that used 'twp_vismach' can now use the standard 'vismach.py' and 'twp_vismach.py' can be removed.
The indenting in the existing vismach code is messy. I have kept most of it to make the changes more easy to follow.
Note that on some systems there is an error message that is related to the text overlay ('hud') object. This is preexisting, prints once and only if a text overlay has been added to the scene:
The only in-tree vismach application that uses the current Hud feature seems to be
/src/emc/usr_intf/axis/scripts/tracking-test.py. The functionality of this is unchanged other than the color of the hud display:Current:

New:
