You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a small addendum to #5423 to ensure there is never a mismatch between the KMS display list generation and display matching code by changing the latter to use the same methodology for matching to kmsgrab monitor index.
Both cases now generate a string using std::format("{}-{}", drmModeGetConnectorTypeName(type), index) and either add it to the display_name list or check if it string matches the value given during kmsgrab display init.
Also adds a log of the final display_names list returned to simplify debugging available display_names.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
feat: New feature (non-breaking change which adds functionality)
fix: Bug fix (non-breaking change which fixes an issue)
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
refactor: Code change that neither fixes a bug nor adds a feature
perf: Code change that improves performance
test: Adding missing tests or correcting existing tests
build: Changes that affect the build system or external dependencies
ci: Changes to CI configuration files and scripts
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit
BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
Code follows the style guidelines of this project
Code has been self-reviewed
Code has been commented, particularly in hard-to-understand areas
Code docstring/documentation-blocks for new or existing methods/components have been added or updated
Unit tests have been added or updated for any new or modified functionality
❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review. ⚠️ Please upload report for BASE (master@c19ad3d). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.
No, this can be merged as it will ensure things work correctly.
For #5444 it'll just help debugging if it fixes that issue by accident then i'd call that a nice by-product.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small addendum to #5423 to ensure there is never a mismatch between the KMS display list generation and display matching code by changing the latter to use the same methodology for matching to kmsgrab monitor index.
Both cases now generate a string using
std::format("{}-{}", drmModeGetConnectorTypeName(type), index)and either add it to the display_name list or check if it string matches the value given during kmsgrab display init.Also adds a log of the final display_names list returned to simplify debugging available display_names.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.