Skip to content

fix: dynamic nv codec sdk selection#5451

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/dynamic-nv-codec-sdk-selection
Draft

fix: dynamic nv codec sdk selection#5451
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/dynamic-nv-codec-sdk-selection

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jul 25, 2026

Copy link
Copy Markdown
Member

Description

Dynamic SDK selection for nvenc.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the fix/dynamic-nv-codec-sdk-selection branch from b493dc2 to 1631383 Compare July 25, 2026 17:27
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.92308% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.11%. Comparing base (c19ad3d) to head (539aec2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/nvenc/nvenc_dynamic_factory.cpp 0.00% 40 Missing ⚠️
src/platform/windows/display_vram.cpp 0.00% 7 Missing and 1 partial ⚠️
src/nvenc/nvenc_shared_dll.h 0.00% 5 Missing ⚠️
src/nvenc/nvenc_dynamic_factory.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5451      +/-   ##
==========================================
+ Coverage   26.89%   27.11%   +0.21%     
==========================================
  Files         111      106       -5     
  Lines       25414    24129    -1285     
  Branches    11236    10669     -567     
==========================================
- Hits         6835     6542     -293     
+ Misses      15568    14687     -881     
+ Partials     3011     2900     -111     
Flag Coverage Δ
Archlinux 0.00% <0.00%> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.73% <100.00%> (+0.48%) ⬆️
Homebrew-macos-14 21.34% <100.00%> (+1.00%) ⬆️
Homebrew-macos-15 22.00% <100.00%> (+1.03%) ⬆️
Homebrew-macos-26 22.11% <100.00%> (+1.01%) ⬆️
Homebrew-ubuntu-24.04 13.34% <100.00%> (+0.40%) ⬆️
Linux-AppImage 12.66% <100.00%> (+0.39%) ⬆️
Windows-AMD64 15.95% <1.63%> (+0.76%) ⬆️
Windows-ARM64 ?
macOS-arm64 18.70% <100.00%> (+0.95%) ⬆️
macOS-x86_64 19.38% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/nvenc/nvenc_version.h 100.00% <100.00%> (ø)
src/platform/common.h 33.07% <ø> (-0.53%) ⬇️
src/video.cpp 54.47% <ø> (+0.60%) ⬆️
src/nvenc/nvenc_dynamic_factory.h 0.00% <0.00%> (ø)
src/nvenc/nvenc_shared_dll.h 0.00% <0.00%> (ø)
src/platform/windows/display_vram.cpp 8.65% <0.00%> (-1.66%) ⬇️
src/nvenc/nvenc_dynamic_factory.cpp 0.00% <0.00%> (ø)

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19ad3d...539aec2. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/dynamic-nv-codec-sdk-selection branch from 1631383 to 539aec2 Compare July 25, 2026 20:47
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
21 New issues
21 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2026.516.143833 broke hardware enc on older nvidia cards

1 participant