fix(packaging/windows): Allow WiX installers to downgrade and overwrite#57
Merged
Merged
Conversation
Update Windows WiX packaging to better support switching between release and PR builds. Set `CPACK_WIX_PROPERTY_REINSTALLMODE` to `amus` so MSI replaces existing files regardless of embedded file versions, and add a custom WiX template with `MajorUpgrade AllowDowngrades="yes"` to remove the default downgrade block.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 24 24
Lines 7303 7303
Branches 2736 2736
========================================
Hits 5555 5555
- Misses 1222 1483 +261
+ Partials 526 265 -261
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Update Windows WiX packaging to better support switching between release and PR builds. Set
CPACK_WIX_PROPERTY_REINSTALLMODEtoamusso MSI replaces existing files regardless of embedded file versions, and add a custom WiX template withMajorUpgrade AllowDowngrades="yes"to remove the default downgrade block.Same as LizardByte/Sunshine#5435
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.