perf(qwen35): optimize packed concurrent prefill on Strix Halo - #595
perf(qwen35): optimize packed concurrent prefill on Strix Halo#595Graffioh wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 67 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
cdba460 to
20ceb72
Compare
There was a problem hiding this comment.
1 issue found across 73 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="server/deps/llama.cpp/ggml/src/ggml-cpu/ops.cpp">
<violation number="1" location="server/deps/llama.cpp/ggml/src/ggml-cpu/ops.cpp:5008">
P1: Padded concurrent-decode rows crash on Metal and can write out of bounds on Vulkan because masked `SET_ROWS` semantics exist only in the CPU/CUDA paths. Add the same negative-index skip or reject/fallback behavior to every backend advertising `GGML_OP_SET_ROWS` before using this op-param.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
c98dbc0 to
fecfb20
Compare
a351ef8 to
045e3e3
Compare
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
ef959a5 to
a90ffe4
Compare
a90ffe4 to
e2f1742
Compare
There was a problem hiding this comment.
All reported issues were addressed across 78 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
e2f1742 to
a873953
Compare
a873953 to
7207c3c
Compare
Summary
Depends on #594. Optimizes Qwen3.6 concurrent prefill on Strix Halo while preserving per-request paged KV and recurrent state isolation.
Validation