feat(harness): add OMP client support - #603
Draft
Graffioh wants to merge 1 commit into
Draft
Conversation
Graffioh
force-pushed
the
agent/omp-harness-support
branch
from
August 12, 2026 20:59
78b6939 to
68af86a
Compare
Graffioh
changed the title
Contributor
Author
|
@cubic-dev-ai review this PR |
Contributor
@Graffioh I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="harness/clients/run_omp.sh">
<violation number="1" location="harness/clients/run_omp.sh:12">
P3: OMP_TIMEOUT is validated only inside run_with_timeout after the server is started and models.yml is written, while OMP_STREAM_IDLE_TIMEOUT_MS is validated up front. Validate OMP_TIMEOUT (non-negative integer, 0 allowed) before sourcing/starting so an invalid deadline fails fast with a clear message.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| : "${OMP_TOOLS:=read,grep,glob}" | ||
| : "${OMP_TIMEOUT:=3600}" | ||
| : "${OMP_STREAM_IDLE_TIMEOUT_MS:=3600000}" | ||
| if [[ ! "$OMP_STREAM_IDLE_TIMEOUT_MS" =~ ^[1-9][0-9]*$ ]]; then |
Contributor
There was a problem hiding this comment.
P3: OMP_TIMEOUT is validated only inside run_with_timeout after the server is started and models.yml is written, while OMP_STREAM_IDLE_TIMEOUT_MS is validated up front. Validate OMP_TIMEOUT (non-negative integer, 0 allowed) before sourcing/starting so an invalid deadline fails fast with a clear message.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At harness/clients/run_omp.sh, line 12:
<comment>OMP_TIMEOUT is validated only inside run_with_timeout after the server is started and models.yml is written, while OMP_STREAM_IDLE_TIMEOUT_MS is validated up front. Validate OMP_TIMEOUT (non-negative integer, 0 allowed) before sourcing/starting so an invalid deadline fails fast with a clear message.</comment>
<file context>
@@ -0,0 +1,81 @@
+: "${OMP_TOOLS:=read,grep,glob}"
+: "${OMP_TIMEOUT:=3600}"
+: "${OMP_STREAM_IDLE_TIMEOUT_MS:=3600000}"
+if [[ ! "$OMP_STREAM_IDLE_TIMEOUT_MS" =~ ^[1-9][0-9]*$ ]]; then
+ echo "OMP_STREAM_IDLE_TIMEOUT_MS must be a positive integer" >&2
+ exit 2
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-responsesprovider support.harness-work/clients/ompValidation
bash harness/tests/test_run_omp_config.sh harness/clients/run_omp.shREAL_OMP_BIN=/home/berto/.local/bin/omp bash harness/tests/test_run_omp_config.sh harness/clients/run_omp.shbash harness/tests/test_client_launcher_timeouts.shbash harness/tests/test_run_pi_timeout.sh harness/clients/run_pi.shpython3 -m py_compile harness/client_test_runner.py harness/clients/summarize_backend_pair.pyuv run --frozen --extra dev ruff check .client_test_runner.py install --clients ompDeferred validation
harness/clients/run_omp.shagainst a live Lucebox model when GPU capacity is availableCLIENT=omp harness/clients/run_backend_pair.shThis is intentionally a draft until the live GPU-backed client run is complete.