docs: finish stripping session residue from comments - #31
Merged
Conversation
Completes the pass started in #30, covering what the first sweep skipped. Two dead string literals in test_workflow_contracts.py sat as no-op statements below the real docstrings, left behind when a docstring was replaced rather than edited. Their content is merged into the docstring above them. The rest is narration: a workflow comment reciting an August call-count chain and a cancelled runner, another naming the date publication last worked, and comments restating the line beneath them.
gabrielspadon
enabled auto-merge (squash)
August 17, 2026 12:21
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the pass started in #30. Prose only, no behaviour change.
Two dead string literals
test_workflow_contracts.pycarried two orphaned string expressions sitting as no-op statements below the real docstrings — left behind when a docstring was replaced rather than edited:Their live content is merged into the docstring above; the archaeology is dropped.
The rest
Narration that dated on arrival: a workflow comment reciting the August call-count chain (
3121, 2686, 2447, 2233) and a cancelled runner, another naming the date publication last worked, and comments restating the line beneath them (# Remove phantom CSV entriesabovereconcile_summary_csv(...)).Kept
# Parse failed - should be rare since we generated the BibTeXwas proposed for deletion and I kept it: it explains why a branch is nearly unreachable, which is not restating the code.Note on method
Automated application broke indentation in
article.py(a deleted comment sat at a different indent from the line below). Caught by ruff, repaired, and the resulting diff for that file is exactly the two intended deletions and nothing else.Verification
ruff clean, mypy clean (55 files), pyrefly 0 errors, pytest 2017 passed, 2 skipped.