Skip to content

docs: finish stripping session residue from comments - #31

Merged
gabrielspadon merged 1 commit into
mainfrom
chore/finish-residue-cleanup
Aug 17, 2026
Merged

docs: finish stripping session residue from comments#31
gabrielspadon merged 1 commit into
mainfrom
chore/finish-residue-cleanup

Conversation

@gabrielspadon

Copy link
Copy Markdown
Collaborator

Completes the pass started in #30. Prose only, no behaviour change.

Two dead string literals

test_workflow_contracts.py carried two orphaned string expressions sitting as no-op statements below the real docstrings — left behind when a docstring was replaced rather than edited:

def test_one_generation_segment_per_run(self) -> None:
    """Asserted against the SHADOW workflow, ..."""
    """The retired workflow swept the whole corpus in a loop until a digest
    stopped moving, ..."""          # <- dead statement, never read

Their live content is merged into the docstring above; the archaeology is dropped.

The rest

Narration that dated on arrival: a workflow comment reciting the August call-count chain (3121, 2686, 2447, 2233) and a cancelled runner, another naming the date publication last worked, and comments restating the line beneath them (# Remove phantom CSV entries above reconcile_summary_csv(...)).

Kept

# Parse failed - should be rare since we generated the BibTeX was proposed for deletion and I kept it: it explains why a branch is nearly unreachable, which is not restating the code.

Note on method

Automated application broke indentation in article.py (a deleted comment sat at a different indent from the line below). Caught by ruff, repaired, and the resulting diff for that file is exactly the two intended deletions and nothing else.

Verification

ruff clean, mypy clean (55 files), pyrefly 0 errors, pytest 2017 passed, 2 skipped.

Completes the pass started in #30, covering what the first sweep skipped.

Two dead string literals in test_workflow_contracts.py sat as no-op statements
below the real docstrings, left behind when a docstring was replaced rather
than edited. Their content is merged into the docstring above them.

The rest is narration: a workflow comment reciting an August call-count chain
and a cancelled runner, another naming the date publication last worked, and
comments restating the line beneath them.
@gabrielspadon
gabrielspadon enabled auto-merge (squash) August 17, 2026 12:21
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@gabrielspadon
gabrielspadon merged commit 11f2ab8 into main Aug 17, 2026
11 checks passed
@gabrielspadon
gabrielspadon deleted the chore/finish-residue-cleanup branch August 17, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant