TARS refactor#13
Open
ZanderKeith wants to merge 16 commits into
Open
Conversation
…on points to prevent synthetic structures
…equilibrium filament tracer tests pass, removed check for coprime number of filaments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications for the refactor of TARS
Major changes:
mirnov.synthetic_signalfor getting direct responses via Biot-Savart (fast), direct responses via ThinCurr (slower, mostly for testing consistency with Biot-Savart method), and frequency responses via ThinCurr (for vessel correction)detect_cocosto clearly state its limitations (cannot actually differentiate between odd vs even, must assume)detect_cocosworks on C-Mod, DIII-D, and TCV shots.EquilibriumField.qpsinow matches COCOS sign, can query newqpsi_abswhen working with |q|