Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ function printHeader() {
}

program
.hook('preAction', () => preFlightChecks());
.hook('preAction', () => {
logger.initializeFileLogging();
preFlightChecks();
});

program
.addHelpText('beforeAll', printHeader())
Expand Down
24 changes: 17 additions & 7 deletions packages/cli/src/util/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function useVerboseConsole(): void {
consoleTransport.level = 'verbose';
}

const dailyRotateFileTransport = new DailyRotateFile({
const dailyRotateFileTransportOptions: DailyRotateFile.DailyRotateFileTransportOptions = {
format: fileFormat,
datePattern: 'YYYY-MM-DD',
dirname: '_markbind/logs',
Expand All @@ -43,15 +43,24 @@ const dailyRotateFileTransport = new DailyRotateFile({
level: 'debug',
maxFiles: 5,
auditFile: '_markbind/logs/audit.json',
});
};

let isFileLoggingInitialized = false;

function initializeFileLogging(): void {
if (isFileLoggingInitialized) {
return;
}

winston.add(new DailyRotateFile(dailyRotateFileTransportOptions));
isFileLoggingInitialized = true;
}

// Reconfigure the default instance logger winston provides with DailyRotateFile for markbind-cli
// Reconfigure the default instance logger winston provides for markbind-cli.
// File logging is added only when a command is about to run.
winston.configure({
exitOnError: false,
transports: [
consoleTransport,
dailyRotateFileTransport,
],
transports: [consoleTransport],
});

export {
Expand All @@ -65,6 +74,7 @@ export {
export {
useDebugConsole,
useVerboseConsole,
initializeFileLogging,
};

// eslint-disable-next-line no-console
Expand Down
15 changes: 15 additions & 0 deletions packages/cli/test/unit/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import fs from 'fs-extra';
import os from 'os';
import path from 'path';
import { spawnSync } from 'child_process';

test('running MarkBind without a command does not create log files', () => {
const workingDirectory = fs.mkdtempSync(path.join(os.tmpdir(), 'markbind-cli-'));
const cliPath = path.resolve(__dirname, '../../dist/index.js');

const result = spawnSync(process.execPath, [cliPath], { cwd: workingDirectory });

expect(result.status).toBe(1);
expect(fs.existsSync(path.join(workingDirectory, '_markbind'))).toBe(false);
fs.removeSync(workingDirectory);
});
Loading