fix(snap-account-service): faster :getLegacySnapKeyring#8865
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Base automatically changed from
cc/fix/snap-account-service-kering-messages-methods
to
main
June 2, 2026 16:08
gantunesr
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Now check if the keyring is already there without locking the
KeyringControllermutex (like we used to do in the clients).References
N/A
Checklist
Note
Medium Risk
Touches legacy keyring access and mutex usage; creation still goes through
withController, but the unsafe read path must not regress concurrency or error handling.Overview
getLegacySnapKeyringnow tries aKeyringController:withKeyringUnsafefast path when the legacy Snap keyring already exists, so it can return without taking thewithControllermutex. If the keyring is missing, behavior is unchanged: it still useswithControllerto find or create the keyring safely.Tests were updated to cover the fast path (no
withController), creation and lookup fallbacks afterKeyringNotFound, and propagation of non–not-found errors from the unsafe path without callingwithController. The unreleased changelog documents the performance change.Reviewed by Cursor Bugbot for commit 6fcadb7. Bugbot is set up for automated code reviews on this repo. Configure here.