chore(transaction-pay-controller): declare @metamask/keyring-controller as a dependency#8972
Merged
cryptodev-2s merged 3 commits intoJun 2, 2026
Merged
Conversation
`src/strategy/relay/hyperliquid-withdraw{,.test}.ts` imports
`@metamask/keyring-controller` at runtime, but the package wasn't
listed in `dependencies`. Add it explicitly so consumers install it
transitively.
matthewwalsh0
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
src/strategy/relay/hyperliquid-withdraw{,.test}.tsimports@metamask/keyring-controllerat runtime, but the package wasn't listed independencies. Consumers were relying on transitive hoisting to install it — once a stricterimport-x/no-extraneous-dependenciesruns (or yarn's hoisting layout changes), the missing dep would surface. This PR adds it explicitly so the dep relationship is correct and consumers get the package installed transitively.Also regenerates
README.mdso the workspace dependency graph reflects the new edge.References
Checklist