Skip to content

chore(transaction-pay-controller): declare @metamask/keyring-controller as a dependency#8972

Merged
cryptodev-2s merged 3 commits into
mainfrom
chore/transaction-pay-controller-add-keyring-dep
Jun 2, 2026
Merged

chore(transaction-pay-controller): declare @metamask/keyring-controller as a dependency#8972
cryptodev-2s merged 3 commits into
mainfrom
chore/transaction-pay-controller-add-keyring-dep

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Jun 2, 2026

Explanation

src/strategy/relay/hyperliquid-withdraw{,.test}.ts imports @metamask/keyring-controller at runtime, but the package wasn't listed in dependencies. Consumers were relying on transitive hoisting to install it — once a stricter import-x/no-extraneous-dependencies runs (or yarn's hoisting layout changes), the missing dep would surface. This PR adds it explicitly so the dep relationship is correct and consumers get the package installed transitively.

Also regenerates README.md so the workspace dependency graph reflects the new edge.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them — N/A

`src/strategy/relay/hyperliquid-withdraw{,.test}.ts` imports
`@metamask/keyring-controller` at runtime, but the package wasn't
listed in `dependencies`. Add it explicitly so consumers install it
transitively.
@cryptodev-2s cryptodev-2s requested review from a team as code owners June 2, 2026 13:16
@cryptodev-2s cryptodev-2s enabled auto-merge June 2, 2026 13:26
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 32e41d3 Jun 2, 2026
370 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/transaction-pay-controller-add-keyring-dep branch June 2, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants