Skip to content

Update howto-network-fabric-quality-of-service.md#4340

Open
rkaraddi wants to merge 3 commits into
MicrosoftDocs:mainfrom
rkaraddi:rkaraddi/qosDocChanges
Open

Update howto-network-fabric-quality-of-service.md#4340
rkaraddi wants to merge 3 commits into
MicrosoftDocs:mainfrom
rkaraddi:rkaraddi/qosDocChanges

Conversation

@rkaraddi

@rkaraddi rkaraddi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixing errors in the QoS doc

@prmerger-automator

prmerger-automator Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@rkaraddi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@prmerger-automator prmerger-automator Bot requested a review from dougbristow June 18, 2026 22:39
@prmerger-automator

prmerger-automator Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@rkaraddi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod

learn-build-service-prod Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 084e9fa:

✅ Validation status: passed

File Status Preview URL Details
operator-nexus/howto-network-fabric-quality-of-service.md ✅Succeeded

For more details, please refer to the build report.

bartpinto
bartpinto reviewed Jun 18, 2026
View reviewed changes

@bartpinto bartpinto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few recommendations below.

Comment thread operator-nexus/howto-network-fabric-quality-of-service.md Outdated
Comment thread operator-nexus/howto-network-fabric-quality-of-service.md
Comment thread operator-nexus/howto-network-fabric-quality-of-service.md Outdated
Comment thread operator-nexus/howto-network-fabric-quality-of-service.md
@Court72 Court72 requested a review from Copilot June 19, 2026 15:04
Copilot AI reviewed Jun 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Operator Nexus QoS documentation to correct the Azure CLI commands used to lock a fabric configuration and commit configuration changes.

Changes:

  • Replaced the configuration lock example with the newer az networkfabric fabric lock-fabric command and parameters.
  • Replaced the commit example with az networkfabric fabric commit-configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread operator-nexus/howto-network-fabric-quality-of-service.md Outdated
Comment thread operator-nexus/howto-network-fabric-quality-of-service.md Outdated
@Court72

Court72 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@dougbristow

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged Tracking label for the PR review team label Jun 19, 2026
@learn-build-service-prod

learn-build-service-prod Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit f1d8c94:

✅ Validation status: passed

File Status Preview URL Details
operator-nexus/howto-network-fabric-quality-of-service.md ✅Succeeded

For more details, please refer to the build report.

@prmerger-automator

prmerger-automator Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod

learn-build-service-prod Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8483519:

✅ Validation status: passed

File Status Preview URL Details
operator-nexus/howto-network-fabric-quality-of-service.md ✅Succeeded

For more details, please refer to the build report.

@prmerger-automator

prmerger-automator Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

PRMerger Results

Issue Description
File Change Percent This PR contains file(s) with more than 30% file change.

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

This pull request has been inactive for 7 days.
If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
If this PR is inactive for 14 more days, it will be closed automatically. Thank you!

@ronmiab

ronmiab commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@eak13 - can you review on behalf of Doug and submit the sign off?

@Court72 - can you change the primary review from Doug to Andrew? We're in the process of updating author assignments.

@v-regandowner v-regandowner assigned eak13 and unassigned dougbristow Jun 29, 2026
@v-regandowner v-regandowner requested a review from eak13 June 29, 2026 14:25
@github-actions github-actions Bot removed the inactive label Jun 29, 2026
learn-build-service-prod Bot pushed a commit that referenced this pull request Jul 2, 2026
@rkaraddi
Update howto-network-fabric-quality-of-service.md (#21147)
094e496 
* Update howto-network-fabric-quality-of-service.md

Mirror of #4340: add fabric update allowed/blocked states and update CLI commands (lock-fabric, commit-configuration).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Apply Learn Authoring Assistant style suggestions

Sentence-case headings, add article, concise present-tense note.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

This pull request has been inactive for 7 days.
If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
If this PR is inactive for 14 more days, it will be closed automatically. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@dougbristow dougbristow Awaiting requested review from dougbristow
@eak13 eak13 Awaiting requested review from eak13
+1 more reviewer
@bartpinto bartpinto bartpinto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@eak13 eak13

Labels

aq-pr-triaged Tracking label for the PR review team azure-operator-nexus/svc Change sent to author do-not-merge inactive needs-human-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rkaraddi @Court72 @ronmiab @bartpinto @eak13 @dougbristow