Skip to content

fix(multinode): use JSON instead of pickle for node-IP exchange to prevent RCE #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix(multinode): use JSON instead of pickle for node-IP exchange to prevent RCE #1419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lightllm/utils/multinode_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ def send_and_receive_node_ip(args):
comm_socket = context.socket(zmq.PULL)
comm_socket.bind(f"tcp://*:{args.multinode_httpmanager_port + i + 100}")
logger.info(f"binding port {args.multinode_httpmanager_port + i + 100}")
args.child_ips.append(comm_socket.recv_pyobj())
# Use JSON instead of pickle: the payload is only the child IP
# string, and recv_pyobj() -> pickle.loads() on a socket bound to
# all interfaces would allow unauthenticated RCE (cf. CVE-2025-32444).
args.child_ips.append(comm_socket.recv_json())
comm_socket.close()
logger.info(f"Received child IPs: {args.child_ips}")
else:
Expand All @@ -28,5 +31,5 @@ def send_and_receive_node_ip(args):
comm_socket = context.socket(zmq.PUSH)
comm_socket.connect(f"tcp://{args.nccl_host}:{args.multinode_httpmanager_port + args.node_rank + 100}")
logger.info(f"connecting to {args.nccl_host}:{args.multinode_httpmanager_port + args.node_rank + 100}")
comm_socket.send_pyobj(local_ip)
comm_socket.send_json(local_ip)
comm_socket.close()