fix(cli): share telemetry shutdown deadline - #2333
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 1b99613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2248
Problem
CLI entrypoints gave each telemetry owner a fresh shutdown timeout. In
kimi web,the kap-server engine pipeline and the host pipeline could therefore extend total
shutdown latency beyond the configured budget. Cleanup rejection handling also
differed between print and web paths.
What changed
deadline, passes only the remaining budget to each pipeline, reports failures,
and continues even if a pipeline or its reporter fails.
RunningServer.close()to kap-server's owned engine telemetry.reporter failure, preserved exit results, and the real kap-server close path.
Test verification (RED → GREEN)
RED on the upstream base:
GREEN with this change:
Full local suite validation used the same five Vitest shards as CI. Shards 3,
4, and 5 passed completely. Shards 1 and 2 reproduced the environment-only
baseline failures from the missing system
zipexecutable; one tree-sitterbudget test that exceeded 50 ms under contention passed in isolation in 16 ms.
The targeted suites, exact changed-package typechecks, build, smoke, sherif, and
pi-tui tests are green. The global type-aware lint process was killed by local
memory pressure, matching the upstream baseline run.
Checklist
gen-changesetsskill; added a patch changeset for the CLI package.gen-docsskill; no documentation update is needed for this internal shutdown policy.