Skip to content

Revert "fix(kosong): match Kimi's standalone "Unsupported image." rejection" #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7Sageer merged 1 commit into from
Jul 29, 2026
Merged

Revert "fix(kosong): match Kimi's standalone "Unsupported image." rejection" #2368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/unsupported-image-standalone-rejection.md
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/agent-core-v2/src/kosong/contract/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ const IMAGE_FORMAT_PROVIDER_MESSAGE_PATTERNS = [

const IMAGE_FORMAT_STATUS_MESSAGE_PATTERNS = [
/unsupported image (?:url|format|type)/,
/unsupported image(?=\s*(?:[.!?]|$))/,
/does not represent a valid image/,
/could not (?:process|decode) (?:the |input )?image/,
/unable to process (?:the |input )?image/,
Expand Down
6 changes: 0 additions & 6 deletions packages/agent-core-v2/test/app/llmProtocol/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,6 @@ describe('isImageFormatError', () => {
),
).toBe(true);
expect(isImageFormatError(new APIStatusError(400, 'unsupported image format'))).toBe(true);
expect(
isImageFormatError(new APIStatusError(400, 'Unsupported image. Please try another one.')),
).toBe(true);
expect(isImageFormatError(new APIStatusError(400, 'Unable to process input image'))).toBe(true);
expect(
isImageFormatError(
Expand Down Expand Up @@ -266,9 +263,6 @@ describe('isImageFormatError', () => {

it('does not match image count/size/support errors that stripping media cannot fix', () => {
expect(isImageFormatError(new APIStatusError(400, 'too many images in request'))).toBe(false);
expect(
isImageFormatError(new APIStatusError(400, 'unsupported image size exceeds the limit')),
).toBe(false);
expect(
isImageFormatError(new APIStatusError(400, 'image dimension 5000 exceeds maximum 2048')),
).toBe(false);
Expand Down
5 changes: 0 additions & 5 deletions packages/kosong/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,6 @@ const IMAGE_FORMAT_PROVIDER_MESSAGE_PATTERNS = [
const IMAGE_FORMAT_STATUS_MESSAGE_PATTERNS = [
// Unsupported format — OpenAI / Moonshot "unsupported image …".
/unsupported image (?:url|format|type)/,
// Standalone-sentence form — Kimi "Unsupported image. …". The
// lookahead keeps the deliberate boundary: phrasings that continue into a
// qualifier ("unsupported image size …", a count/size limit) must not
// match, so only punctuation- or end-terminated occurrences classify.
/unsupported image(?=\s*(?:[.!?]|$))/,
// Undecodable / corrupt image data.
/does not represent a valid image/,
/could not (?:process|decode) (?:the |input )?image/,
Expand Down
9 changes: 0 additions & 9 deletions packages/kosong/test/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,10 +585,6 @@ describe('isImageFormatError', () => {
),
).toBe(true);
expect(isImageFormatError(new APIStatusError(400, 'unsupported image format'))).toBe(true);
// Kimi standalone-sentence form (actual production message)
expect(
isImageFormatError(new APIStatusError(400, 'Unsupported image. Please try another one.')),
).toBe(true);
// Gemini
expect(isImageFormatError(new APIStatusError(400, 'Unable to process input image'))).toBe(true);
expect(
Expand Down Expand Up @@ -628,11 +624,6 @@ describe('isImageFormatError', () => {
// model blind to the user's images — hiding the real error. They must
// surface instead of triggering a media-stripped resend.
expect(isImageFormatError(new APIStatusError(400, 'too many images in request'))).toBe(false);
// Qualifier-continuing phrasing: the standalone-sentence pattern must
// not swallow count/size variants of "unsupported image …".
expect(
isImageFormatError(new APIStatusError(400, 'unsupported image size exceeds the limit')),
).toBe(false);
expect(
isImageFormatError(new APIStatusError(400, 'image dimension 5000 exceeds maximum 2048')),
).toBe(false);
Expand Down
Loading