feat(acp): expose steering over ACP via _session/steering extension method - #2374
Open
adwaitm1301 wants to merge 2 commits into
Open
feat(acp): expose steering over ACP via _session/steering extension method#2374adwaitm1301 wants to merge 2 commits into
adwaitm1301 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 059263b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0689de88
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements issue #2370 by exposing Kimi Code's existing steering capability through the ACP extension method surface.
The AcpServer.initialize() response now advertises _meta.steering.supported: true so ACP clients can detect the runtime capability without any per vendor branching. When a client calls _session/steering with a sessionId and prompt blocks during an active turn, the adapter converts the blocks and injects them into the running turn via the core SDK's Session.steer() which the TUI already uses with Ctrl+S.
If no turn is active, the adapter returns { outcome: 'noActiveTurn' } instead of starting a detached turn, letting the host fall back to a regular session/prompt. This avoids the startedNewTurn problem observed in other ACP adapters where a terminal turn gets created that nobody owns, causing discarded responses and lifecycle issues.
The changes are minimal because the core SDK already had Session.steer(), the conversion layer acpBlocksToPromptParts() already existed, and the adapter already held the Session instance. The adapter simply tracks whether a turn is in flight through its existing currentTurnId field which is updated by the event listener in prompt() and reset on turn.ended.
Testing: all 326 existing tests in the acp-adapter package pass, and the full monorepo typecheck passes.