Conversation
…eometry - Comment out tracker virtual detectors in VirtualDetectorMaker.cc - Add hasProtonAbsorber check in constructStoppingTarget.cc for safety - Add geom_run1_b_v01.txt with Run1B configuration - Disable TSdA, set Coll51 to DSVacuum material
- Disable proton absorber, STM, TSdA for Run1B configuration - Place tracker and calorimeter in DS2Vacuum with extended DS2 length (3646 mm) - Disable service pipes and rails to prevent DS3Vacuum overlaps - Fix StoppingTargetMother radius calculation using std::max for proper containment - Adjust bearing blocks: reduce size by 70% and move radially outward to ±550mm - Increase tracker mother half-length to 1640mm to contain end rings - Set Coll51 material to DSVacuum and disable TSdA - Re-enable virtual detectors and fix virtual detector placement logic - Add gdmldump_run1_b_v01.fcl for geometry validation All geometry overlaps resolved: 0 overlaps detected in final validation.
let some gdml fail, but don't fail the build
allow some gdml combinations to fail
changed EventDisplay to allow Run1b geometry
Optionally produce the EWM as well as the event header
Run 1B: Merge main into Run 1B
Merge pull request #1693 from michaelmackenzie/EWMFromCFO
new virtual detectors
Add geom_run1_b_v02: TSdA poly absorber behind ST
Remerge main into Run1B branch
Merge main to Run1B
Remerge main into Run1B
Run1B: Merge main
Add v40 Run 1B config
Add flexibility to add configuration changes for Run 1B targets
Overlap fixes
Add back services and normal DS volume
Resolve `main` → `Run1B` merge conflicts for PR #1847
Collaborator
|
Hi @oksuzian,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for 813ecd1: build (Build queue - API unavailable) |
Collaborator
|
☀️ The build tests passed at 813ecd1.
N.B. These results were obtained from a build of this Pull Request at 813ecd1 after being merged into the base branch at 83b5e2f. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.