fix(chu): 添加 Umiguri 新版本头部标签到静默忽略列表#4
Conversation
审阅者指南(在小型 PR 上折叠)审阅者指南向 UgcParser 的“静默忽略”头标签列表中添加了若干新的 Umiguri 专用头标签,这样它们将不再产生“未知头标签”的 info 级别提示,因为它们仅用于元数据/渲染,不影响谱面转换逻辑。 文件级变更
提示与命令与 Sourcery 交互
自定义你的体验访问你的控制面板 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideAdds several new Umiguri-specific header tags to the UgcParser’s silently-ignored header list so they no longer emit "unknown header tag" info-level alerts, as they are metadata/rendering-only and do not affect chart conversion logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Code Review
This pull request adds several UGC header tags to the silent ignore list in UgcParser.cs. However, adding @ENDHEAD to this list introduces a potential bug where the parser fails to transition out of the header state if the tag contains trailing whitespace, leading to empty note lists. It is recommended to handle @ENDHEAD using robust tag extraction logic in the main parse loop instead.
添加以下 Umiguri 新版本使用的头部标签到 UgcParser 的静默忽略列表:
这些标签是 Umiguri 的元数据/渲染相关标签,对转谱逻辑不影响,之前会触发「未知头部标签」的 Info 级别警告。
Summary by Sourcery
错误修复:
Original summary in English
Summary by Sourcery
Bug Fixes: