Skip to content

WPP-11685-updated PR workflow#169

Open
faridahsalami-nhs wants to merge 11 commits into
masterfrom
feature/WPP-11685-update-pr-workflow
Open

WPP-11685-updated PR workflow#169
faridahsalami-nhs wants to merge 11 commits into
masterfrom
feature/WPP-11685-update-pr-workflow

Conversation

@faridahsalami-nhs

@faridahsalami-nhs faridahsalami-nhs commented Jul 21, 2026

Copy link
Copy Markdown

Summary

This pull request introduces changes to the PR Quality Check GitHub Actions workflow (pr-lint.yaml) to enable it to post a comment on the PR with a link a WPP Jira Ticket, when one is included in the branch name from which the PR is created. This type of feature existed previously in this workflow but it didn't work for tickets with out current WPP Jira prefix. These changes also remove the ability for no-longer-used Jira ticket prefixes, such as APM and AMP, to trigger the creation of a comment.

Additional changes:

  • added functionality for workflow to comment on a PR with instructions on what to do when when a PR has been raised from a branch which does not have a valid Jira ticket number in the branch name. After the comment is posted the workflow fails.
  • The Check ticket name conforms to requirements step has been refactored to use built-in bash commands rather than grep, as pattern matching can be achieved without spawning a subprocess to run grep, which is slightly more efficient.

Unchanged:

  • branches starting dependabot/ are still valid and will not cause the PR Quality Check to fail.

TESTING:

  • This workflow has been tested on this branch and the relevant Jira ticket comment with link can be seen posted, on July 23rd at 16:32, lower down this page.
  • The unhappy path, where a warning message is posted, has been tested via draft PR add alternate pr-lint workflow #170. That PR will be closed once this one has been merged. Please check that comment's content and styling while reviewing this PR.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Copilot AI review requested due to automatic review settings July 21, 2026 15:54
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@faridahsalami-nhs faridahsalami-nhs changed the title updated PR workflow WPP-11685-updated PR workflow Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR lint GitHub Actions workflow to recognize WPP-#### ticket branch names and use them when posting JIRA links on PRs.

Changes:

  • Extend branch-name validation regex to include wpp-[0-9]+.
  • Extend ticket extraction and PR-comment conditions to include wpp- / WPP-.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr-lint.yaml Outdated
Comment thread .github/workflows/pr-lint.yaml Outdated
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

WPP-11685

from the pr-lint workflow
for use when a Jira ticket number has not been included in the branch
in check ticket name step
in the comment on pr with ticket number step
to use built-in bash commands rather than grep for pattern matching
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital WPP JIRA Project. Here's a handy link to the ticket:

WPP-11685

@edwardbowyer-nhs edwardbowyer-nhs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can see it working in both happy and sad paths.
Is there corss-over with Utilities we could make use of to ?

@stevesmith-nhs

Copy link
Copy Markdown
Contributor

as mentioned in teams - this might replicate some of the existing checks done in the reusable actions myself and @chetan-nhs-acn have been working on and the existing RAA ones, can you take a look at the actions we have just to ensure we aren't duplicating anything, particarly the branch and PR title validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants