Remove config.com dependency from GDASApp#2183
Conversation
DavidHuber-NOAA
requested review from
AndrewEichmann-NOAA,
CoryMartin-NOAA and
guillaumevernieres
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
g-w PR #5068 uses the GDASApp hash from this PR. g-w PR #5068 documented that g-w CI passes with the changes in the g-w PR and this GDASApp PR.
g-w CI does not directly exercise the GDASApp jjob scripts modified by this PR. Given this, build g-w PR #5068 on Dogwood with GDASApp g-w CI turned on. This is done for two reasons. (1) confirm that the changes in this PR work for these ctests. (2) see if GDASApp ctests, including select g-w CI, work when using GFS v17 branches.
GDASApp ctests are not part of pre-implementation testing. Therefore, approve.
AndrewEichmann-NOAA
left a comment
AndrewEichmann-NOAA
left a comment
There was a problem hiding this comment.
No objections if it works, though I haven't worked with GDASApp ctests in a while
AntonMFernando-NOAA
force-pushed
the
feature/gfsv17-gdas_config_com
branch
from
930f384 to
8b0e395
Compare
|
@RussTreadon-NOAA @CoryMartin-NOAA @DavidNew-NOAA @AndrewEichmann-NOAA @DavidHuber-NOAA The scripts were further updated to reflect the recommendation against using template scripts. |
| '${MEMDIR}': 'mem%03d' | format(imem) }) %} | ||
| - ['{{ COM_ATMOS_HISTORY_TMPL | replace_tmpl(tmpl_dict) }}/{{ GPREFIX_ENS }}csg_atm.f006.nc', '{{ DATA }}/ens/{{ 'mem%03d' | format(imem) }}/{{ GPREFIX_ENS }}cubed_sphere_grid_atmf006.nc'] | ||
| - ['{{ COM_ATMOS_HISTORY_TMPL | replace_tmpl(tmpl_dict) }}/{{ GPREFIX_ENS }}csg_sfc.f006.nc', '{{ DATA }}/ens/{{ 'mem%03d' | format(imem) }}/{{ GPREFIX_ENS }}cubed_sphere_grid_sfcf006.nc'] | ||
| {% set ens_hist_prev = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} |
There was a problem hiding this comment.
Since these are still COM variables I would suggest changing these variables being set to still use the COM nomenclature. Then as part of #3340 we would highlight in the respective J-Jobs that things are being set down here
| {% set ens_hist_prev = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} | |
| {% set COM_ATMOS_HISTORY_MEM_PREV = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} |
|
@TravisElless-NOAA See the new changes. |
| '${MEMDIR}': 'mem%03d' | format(imem) }) %} | ||
| - ['{{ COM_ATMOS_HISTORY_TMPL | replace_tmpl(tmpl_dict) }}/{{ GPREFIX_ENS }}csg_atm.f006.nc', '{{ DATA }}/ens/{{ 'mem%03d' | format(imem) }}/{{ GPREFIX_ENS }}cubed_sphere_grid_atmf006.nc'] | ||
| - ['{{ COM_ATMOS_HISTORY_TMPL | replace_tmpl(tmpl_dict) }}/{{ GPREFIX_ENS }}csg_sfc.f006.nc', '{{ DATA }}/ens/{{ 'mem%03d' | format(imem) }}/{{ GPREFIX_ENS }}cubed_sphere_grid_sfcf006.nc'] | ||
| {% COMIN_ATMOS_HISTORY_PREV_MEM = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} |
There was a problem hiding this comment.
Just a minor suggestion from me would be to switch the order of MEM and other additional descriptors (PREV, ENSSTAT, etc.) throughout to be consistent with other COM variables.
Additionally can you point to the location of the CI log files that NOAA-EMC/global-workflow#5068 ran with these updates just as a double check to make sure things are being rendered correctly
| {% COMIN_ATMOS_HISTORY_PREV_MEM = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} | |
| {% COMIN_ATMOS_HISTORY_MEM_PREV = ROTDIR ~ '/enkfgdas.' ~ (previous_cycle | to_YMD) ~ '/' ~ (previous_cycle | strftime('%H')) ~ '/' ~ ('mem%03d' | format(imem)) ~ '/model/atmos/history' %} |
6 participants
Description
config.comis a legacy configuration mechanism that should be completely removed from the GDASApp. Currently, it is still referenced in:Companion PRs
Issues
Automated CI tests to run in Global Workflow