Adds support for reordering=False in Butina clustering#220
Open
Matthew-Neba wants to merge 8 commits into
Open
Adds support for reordering=False in Butina clustering#220Matthew-Neba wants to merge 8 commits into
reordering=False in Butina clustering#220Matthew-Neba wants to merge 8 commits into
Conversation
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Collaborator
|
Thanks for the contribution! This looks great, and we can definitely get it in for v0.6. A few comments, mostly minor. |
scal444
reviewed
Jul 6, 2026
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Author
|
Thanks for all the help! I have fixed the issues you pointed out. I have managed to parallelize that kernel and fixed the other minor issues aswell. I could indeed use the blockReduce idea you mentioned and it works well. |
Collaborator
|
Looks great! Can you install ruff 0.15.8 and clang-format-17, and then run admin/run_clang_format.sh and admin/run_ruff_format.sh to get it to pass the linters? |
Collaborator
|
Or i can do it and push a commit if you're ok with that |
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
Author
|
No worries, I ran the formatters. I also fixed an issue that was leading to the forge build failing. Hopefully all loose ends are tied now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
reordering=Falsein Butina clustering. Fixes #192Changes
reorderingoption to the Python and C++ Butina APIs.reordering=False.