Skip to content

Update NVSkill CI to latest template - #6448

Merged
rostan-t merged 1 commit into
NVIDIA:mainfrom
rostan-t:update-skill-ci
Aug 11, 2026
Merged

Update NVSkill CI to latest template#6448
rostan-t merged 1 commit into
NVIDIA:mainfrom
rostan-t:update-skill-ci

Conversation

@rostan-t

Copy link
Copy Markdown
Collaborator

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Update NVSkill CI to the latest template.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
@rostan-t rostan-t added trivial change agent skill Related to an agent skill. Two PRs related to the same skill should not exist at the same time. labels Aug 11, 2026
@JanuszL JanuszL self-assigned this Aug 11, 2026
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the NVSkills request workflow to run automatically for pull-request lifecycle events and grants status-read permission.

  • Adds opened, reopened, synchronize, and ready-for-review triggers.
  • Routes pull-request events directly to the reusable NVSkills request workflow.
  • Adds read access to commit statuses.

Confidence Score: 4/5

The fork pull-request path needs to be handled before merging because it cannot authenticate the newly automatic NVSkills request.

The unconditional pull-request trigger reaches a secret-authenticated reusable workflow even for fork events, where repository secrets are unavailable, leaving external contributors without the intended automatic NVSkills request.

Files Needing Attention: .github/workflows/request-nvskills-ci.yml

Important Files Changed

Filename Overview
.github/workflows/request-nvskills-ci.yml Adds automatic pull-request dispatching, but fork-originated events cannot provide the repository dispatch-token secret required by the request flow.

Fix All in Claude Code

Reviews (1): Last reviewed commit: "Update NVSkill CI to latest template" | Re-trigger Greptile

Comment thread .github/workflows/request-nvskills-ci.yml
@rostan-t
rostan-t merged commit 54c3f96 into NVIDIA:main Aug 11, 2026
8 checks passed
@rostan-t
rostan-t deleted the update-skill-ci branch August 11, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent skill Related to an agent skill. Two PRs related to the same skill should not exist at the same time. trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants