Skip to content

feat: switch hosted OCR CPU actor defaults to Nemotron OCR v2#2295

Merged
charlesbluca merged 7 commits into
NVIDIA:mainfrom
kheiss-uwzoo:feat/hosted-ocr-v2-defaults
Jul 15, 2026
Merged

feat: switch hosted OCR CPU actor defaults to Nemotron OCR v2#2295
charlesbluca merged 7 commits into
NVIDIA:mainfrom
kheiss-uwzoo:feat/hosted-ocr-v2-defaults

Conversation

@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator

Summary

Switch hosted/remote CPU OCR actor DEFAULT_INVOKE_URL values from nemotron-ocr-v1 to nemotron-ocr-v2, and align README/CLI examples, library-mode CI, and tests.

Draft — for eng review. Split from #2259 per Randy's guidance: docs PR stays docs-only; this change waits for eng sign-off on hosted endpoint readiness.

On main, hosted defaults remain v1 intentionally (#2021: v2 available locally and in Helm, remote flip deferred).

Changes

  • Operators: ocr/cpu_ocr.py, chart/cpu_actor.py, table/cpu_actor.py, video/ocr_actor.py
  • README/CLI example invoke URLs
  • Library-mode CI: OCR_INVOKE_URL → v2
  • Tests asserting default remote URLs

PR scope check

  • Base: main
  • Files changed: 12 — 4 operators, 5 tests, README/CLI, 1 CI workflow
  • Red flags: .github/workflows/integration-test-library-mode.yml (OCR invoke URL only)

Test plan

  • pytest nemo_retriever/tests/test_operator_flags_and_cpu_actors.py nemo_retriever/tests/test_video_frame_ocr_actor.py
  • Confirm library-mode integration workflow uses nemotron-ocr-v2
  • Verify hosted v2 endpoint is GA before merging

Update remote DEFAULT_INVOKE_URL values, library-mode CI, README/CLI
examples, and tests to match Helm v2 defaults (NVIDIA#2239). Clarify that
TableStructureCPUActor has no default OCR URL.
Comment thread .github/workflows/integration-test-library-mode.yml Outdated
Comment thread nemo_retriever/tests/test_readme_video_pipeline_example.py Outdated
Align library-mode CI and README video tests with operator defaults and
build.nvidia.com hosted model name (nemotron-ocr-v2).
@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator Author

Addressed the nemoretriever-ocr-v2 callout in dde7529a: library-mode CI and README video tests now use nemotron-ocr-v2, matching operator DEFAULT_INVOKE_URL values and build.nvidia.com.

kheiss-uwzoo added a commit to kheiss-uwzoo/nv-ingest that referenced this pull request Jul 2, 2026
Documents hosted CPU actor defaults after NVIDIA#2295 lands. Merge NVIDIA#2295
before this PR per eng review.
@kheiss-uwzoo kheiss-uwzoo self-assigned this Jul 7, 2026
@kheiss-uwzoo kheiss-uwzoo added the doc Improvements or additions to documentation label Jul 7, 2026
@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator Author

Addressed both review comments in \dde7529a\ and rebased onto latest \main\ (\�5404c05):

  • Library-mode CI (.github/workflows/integration-test-library-mode.yml): \OCR_INVOKE_URL\ now uses
    emotron-ocr-v2\ (not
    emoretriever-ocr-v2).
  • README video pipeline tests (\ est_readme_video_pipeline_example.py): both \ocr_invoke_url\ fixtures updated to
    emotron-ocr-v2.

Review threads resolved. PR diff remains scoped to the 12 OCR-default files.

@kheiss-uwzoo
kheiss-uwzoo marked this pull request as ready for review July 13, 2026 19:06
@kheiss-uwzoo
kheiss-uwzoo requested review from a team as code owners July 13, 2026 19:06
@kheiss-uwzoo
kheiss-uwzoo requested a review from jperez999 July 13, 2026 19:06
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR switches hosted OCR defaults and examples to Nemotron OCR v2. The main changes are:

  • Hosted CPU OCR actor defaults now point at nemotron-ocr-v2.
  • Video frame CPU OCR defaults now point at nemotron-ocr-v2.
  • README, CLI examples, workflow env, and tests now use the v2 OCR URL.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
nemo_retriever/src/nemo_retriever/operators/extract/ocr/cpu_ocr.py Updates the hosted CPU OCR default endpoint to nemotron-ocr-v2.
nemo_retriever/src/nemo_retriever/operators/extract/video/ocr_actor.py Updates the video frame CPU OCR default endpoint to nemotron-ocr-v2.
.github/workflows/integration-test-library-mode.yml Updates the library-mode integration OCR invoke URL to the hosted v2 endpoint.
nemo_retriever/src/nemo_retriever/operators/extract/table/cpu_actor.py Clarifies that table OCR is only used when an OCR invoke URL is provided.

Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile

Comment thread nemo_retriever/src/nemo_retriever/operators/extract/ocr/cpu_ocr.py
@kheiss-uwzoo
kheiss-uwzoo marked this pull request as draft July 13, 2026 19:14
…defaults

# Conflicts:
#	.github/workflows/integration-test-library-mode.yml
#	nemo_retriever/src/nemo_retriever/operators/extract/chart/cpu_actor.py
#	nemo_retriever/tests/test_operator_flags_and_cpu_actors.py
@kheiss-uwzoo
kheiss-uwzoo marked this pull request as ready for review July 14, 2026 19:16
@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator Author

Rebased onto latest \main\ (\�ec74047) — merge conflicts are resolved.

Conflict resolutions:

  • .github/workflows/integration-test-library-mode.yml: kept
    emotron-ocr-v2; dropped \GRAPHIC_ELEMENTS_INVOKE_URL\ (chart operator removed on main)
  • \chart/cpu_actor.py: accepted deletion (entire chart/graphic-elements operator removed on main)
  • \ est_operator_flags_and_cpu_actors.py: removed \TestGraphicElementsCPUActor\ (tested deleted actor)

Hosted OCR v2 defaults remain on the surviving CPU actors (\ocr/cpu_ocr.py, \�ideo/ocr_actor.py), README/CLI examples, and CI. Unit tests green.

@charlesbluca — ready for your re-review when you have a moment.

@charlesbluca
charlesbluca merged commit b10bd89 into NVIDIA:main Jul 15, 2026
3 checks passed
kheiss-uwzoo added a commit to kheiss-uwzoo/nv-ingest that referenced this pull request Jul 15, 2026
Unify Helm NIM inventory and NVCF endpoint correlation per Charles
review on NVIDIA#2259/NVIDIA#2295. Emphasize hosted OCR v2 language-mode limits;
move deploy how-to to owning pages. Includes anchor, column, and
answer_llm endpoint follow-ups from PR review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants