[NVBUG-6448152][test] isolate PP rendezvous from global commit#16580
Draft
chienchunhung wants to merge 6 commits into
Draft
[NVBUG-6448152][test] isolate PP rendezvous from global commit#16580chienchunhung wants to merge 6 commits into
chienchunhung wants to merge 6 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> (cherry picked from commit 833ddd2) Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Apply only the CacheSender readiness synchronization portion of NVIDIA#15737 to the exact NVIDIA#15139 boundary experiment. This keeps the historical control and treatment matched while removing the known lost-wakeup confound. Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Keep the historical experiment tree unchanged while making the diagnostic PR mergeable for the Blossom launch gate. Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
Collaborator
|
PR_Github #60200 [ run ] triggered by Bot. Commit: |
Collaborator
Author
|
/bot run --disable-fail-fast --stage-list "A30-CPP-Post-Merge-1,A30-CPP-Post-Merge-2,DGX_H100-4_GPUs-CPP-1,DGX_H100-4_GPUs-PyTorch-Others-1,DGX_H100-4_GPUs-PyTorch-Others-2" |
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question
Does replacing #15139's synchronous CTX TP/PP outcome collectives with asynchronous point-to-point agreement recover the adjacent pre-#15139 throughput, even when request/KV resources remain retained until global commit?
Design
P-1is the coordinator; [NVBUG-6448152][test] trace disagg transfer lifecycle #16567 showed it naturally reaches the terminal-status point last.{request, success|failure}vote without waiting.This preserves a common ordered decision across ranks, but application is asynchronous rather than simultaneous in wall-clock time.
Exact experiment
c58a3ac9be5ca30d69a5d326f250768b021f97f2([TRTLLM-12721][feat] Add disagg transfer state consensus #15139 treatment plus the common [https://nvbugs/6342844][fix] Prevent disaggregated KV transfer stalls #15737 sender fix)dc06e82a182671a0d9626243d660a44a3b73bd1d68e92a26956da25a659860082da887567b9d36c35e2498b46a71f53f39fd641b3d5566cd4dd11f4d176041ba15f25fda876ccfa209d04896a003dc68dataTransceiver.cppblob preserved:b3eb1c0f984394e798993708bebcabe885ea1644TRTLLM_NVBUG_6448152_CTX_COORDINATOR_CONSENSUS=1Targeted validation
Stage:
GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1Selector:
disagg_upload-e2e-gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-NIXLA throughput result is valid only with 512/512 successful requests. Compare with:
Risks / limitations
Dependency and experiment graph
flowchart LR C["#16565<br/>pre-#15139 + #15737<br/>1557.83 tok/s"] T["#16566 / #16567<br/>post-#15139 + #15737<br/>~818 tok/s before teardown"] A["#16580<br/>async PP agreement<br/>global KV retention"] B["#16581<br/>same agreement traffic<br/>local-success KV reclamation"] L["#16572<br/>local-only unsafe control<br/>1564.71 tok/s"] C -->|"#15139 only"| T T --> A A --> B T --> LInterpretation: A at least 90% of #16565 means exposed rendezvous dominated. A low but B at least 90% means retained KV/admission was the remaining dominant cost. Partial recovery in both means both contribute. Any failed request censors throughput.