Improve device-init grouped linear module with single grouped weight support #3224
Draft
zhongbozhu wants to merge 3 commits into
Draft
Improve device-init grouped linear module with single grouped weight support #3224zhongbozhu wants to merge 3 commits into
zhongbozhu wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
community-contribution
zhongbozhu
force-pushed
the
improve_device_grouped_linear
branch
from
July 20, 2026 22:36
aa3b9d1 to
47ba66a
Compare
timmoon10
reviewed
Jul 20, 2026
| EXPERIMENTAL and subject to change. Gated by the | ||
| ``NVTE_GROUPED_LINEAR_SINGLE_PARAM`` environment variable: if the env var | ||
| is not set this argument is forced to ``False`` with a warning. | ||
| grouped_gemm_backend : {"legacy", "grouped_tensor"}, default = None |
Member
There was a problem hiding this comment.
It's unintuitive that grouped_gemm_backend="grouped_tensor" might end up using split-quantize internally. What do you think about the following:
"split_tensors": Use split-quantize impl"grouped_tensor": User promises split points are valid for grouped GEMM kernel. Use grouped tensor impl, or error out if not supported."prefer_grouped_tensor": User promises split points are valid for grouped GEMM kernel. Use grouped tensor impl, or fallback to split-quantize impl if not supported.
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
zhongbozhu
force-pushed
the
improve_device_grouped_linear
branch
from
July 20, 2026 22:53
ff7eee2 to
a43f70f
Compare
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
for more information, see https://pre-commit.ci
| @staticmethod | ||
| def _is_grouped_tensor_path_supported( | ||
| *, | ||
| grouped_gemm_backend: str, |
Contributor
There was a problem hiding this comment.
If we accept raw str, lets make sure to document the allowed options in the docstring below
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: