test: skip system NVML tests when the symbol is absent in older bindings#2390
Open
rluo8 wants to merge 3 commits into
Open
test: skip system NVML tests when the symbol is absent in older bindings#2390rluo8 wants to merge 3 commits into
rluo8 wants to merge 3 commits into
Conversation
|
rluo8
force-pushed
the
fix/skip-missing-nvml-symbol
branch
from
July 20, 2026 07:19
6955804 to
7f9f7ee
Compare
mdboom
requested changes
Jul 20, 2026
mdboom
left a comment
Contributor
There was a problem hiding this comment.
unsupported_before is meant to indicate that a feature isn't available on a specific hardware architecture. It's not meant to indicate that a function isn't available on a specific CTK version.
We should skip each of the failing tests individually, based on the CTK version.
For example:
@pytest.mark.skipif(get_user_mode_driver_version() < (13, 0))
Member
|
I think we should check the KMD version not UMD version? |
rluo8
force-pushed
the
fix/skip-missing-nvml-symbol
branch
from
July 21, 2026 02:36
7f9f7ee to
7433f3a
Compare
Contributor
Author
|
Thanks @mdboom , @leofang. I updated the patch to skip the two cases when kernel mode driver < R580. Verified on a forward compatibility system (UMD 13.0 + KMD 575), the tests would still fail with FunctionNotFoundError if using UMD check. After switching to use KMD version check, the two tests could be skipped correctly. |
mdboom
approved these changes
Jul 21, 2026
mdboom
enabled auto-merge (squash)
July 21, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix bug 6179497, and it's a test only issue.
Tests failed when using cuda.core v1.1.0 and cuda bindings 12.9.7.
FAILED system/test_system_device.py::test_addressing_mode
FunctionNotFoundError: function nvmlDeviceGetAddressingMode is not found
FAILED system/test_system_device.py::test_repair_status
FunctionNotFoundError: function nvmlDeviceGetRepairStatus is not found
This issue was originally fixed in pr #1898, but the fix in cuda.bindings wasn't inculded in cuda 12.9.x.
This fix back-stops the skip on the cuda.core test side (independent of the cuda.bindings version): a missing NVML symbol is skipped rather than failed.
Checklist