Make Windows pathfinder dynamic library searches architecture-aware#2393
Open
isVoid wants to merge 2 commits into
Open
Make Windows pathfinder dynamic library searches architecture-aware#2393isVoid wants to merge 2 commits into
isVoid wants to merge 2 commits into
Conversation
Contributor
Contributor
Author
|
/ok to test |
Contributor
@isVoid, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
Author
|
/ok to test 1d0a111 |
|
isVoid
force-pushed
the
codex/pathfinder-windows-arch-search-ctk-next
branch
from
July 21, 2026 16:38
1d0a111 to
3247072
Compare
Contributor
Author
|
/ok to test 3247072 |
isVoid
commented
Jul 21, 2026
| } | ||
| SITE_PACKAGES_LIBDIRS_LINUX = SITE_PACKAGES_LIBDIRS_LINUX_CTK | SITE_PACKAGES_LIBDIRS_LINUX_OTHER | ||
|
|
||
| # Historical table exports represent the original x64 catalog. |
Contributor
Author
There was a problem hiding this comment.
Q: What should we list here? Historically it's only listing the x64 catalog. But should we instead list all available items?
leofang
reviewed
Jul 21, 2026
| import sysconfig | ||
|
|
||
|
|
||
| class UnsupportedWindowsArchError(RuntimeError): |
Member
There was a problem hiding this comment.
We can just call it UnsupportedArchError in case we want to use it elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
CUDA Toolkit 13.4 installs Windows binaries in architecture-specific directories such as
bin/x64andbin/arm64. CUDA 13 wheels likewise use architecture-specific directories undernvidia/cu13/bin, while CUDA 12 component wheels retain their existing package-specific layouts.Validation
ruff checkpassed for all changed Python files.ruff format --checkpassed for all changed Python files.