[KMeans] Rename streaming_batch_size param#2328
Merged
Merged
Conversation
tarang-jain
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jinsolp
reviewed
Jul 22, 2026
jinsolp
left a comment
jinsolp
left a comment
Contributor
There was a problem hiding this comment.
Can we call it n_device_buffer_samples to make it obvious that it's the number of samples?
cjnolet
reviewed
Jul 22, 2026
…nto rename-params
… rename-params
Contributor
Author
I think @jinsolp lets not make param names even longer. |
cjnolet
approved these changes
Jul 22, 2026
Contributor
Author
|
/merge |
rapids-bot
Bot
merged commit Jul 23, 2026
ab79f9a
into
NVIDIA:release/26.08
163 of 165 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
streaming_batch_sizeparam for kmeans to:batch_samplesandbatch_centroidsparamsThe idea is that the
streamingword can be misleading. We are "buffering up" a batch of samples onto the device.Merge after #2329