add support for overriding fields in fabricmanager.cfg - #893
Open
tariq1890 wants to merge 1 commit into
Open
Conversation
|
@tariq1890 In the interest of just tweaking fabric-mode, this PR looks correct to me. But what about other configuration tweaks like the resiliency mode and the FM service connection method? Are they going to be handled in separate PRs? |
tariq1890
changed the title
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Contributor
Author
|
Thanks for taking a look @varunrsekar. I have extended the implementation to make it more generic. Now, users can override the fabric manager config field of their choice by providing the environment variables with this format - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow gpu-driver-container users to override fabric manager config before starting the fabricmanager daemon on their NVSwitch GPU systems. With this change, the gpu-driver-container will the parse environment variables with the
NVFM_CONFIG_prefix and modify the/usr/share/nvidia/nvswitch/fabricmanager.cfgfile with the desired fabric manager config before starting up fabricmanager.