fix(docs-version-sync): use the .git marker for the repo root - #550
Open
mesutoezdil wants to merge 1 commit into
Open
fix(docs-version-sync): use the .git marker for the repo root#550mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRepository guidance now uses nested ChangesRepository-root resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sbaum1994
approved these changes
Jul 30, 2026
sbaum1994
requested changes
Jul 30, 2026
mesutoezdil
force-pushed
the
mesutoezdil/fix/docs-version-sync-repo-root
branch
from
July 30, 2026 08:19
59f0ad5 to
7b812e7
Compare
mesutoezdil
force-pushed
the
mesutoezdil/fix/docs-version-sync-repo-root
branch
from
July 31, 2026 06:47
d60368f to
61ac660
Compare
findRepoRoot looked for imports.yaml, which this repository does not use, so `go run -C tools/docs-version-sync . --target main` failed with "imports.yaml not found". Resolve the root from the .git marker instead and drop the imports.yaml references from the root AGENTS.md. Closes NVIDIA#549 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
mesutoezdil/fix/docs-version-sync-repo-root
branch
from
August 1, 2026 07:54
61ac660 to
f1805d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
go run -C tools/docs-version-sync . --target main, the command indocs/AGENTS.md, failed withimports.yaml not found.findRepoRootlooked forimports.yaml, which this repository does not use. It now resolves the root from the.gitmarker, and theimports.yamlreferences are removed from the rootAGENTS.md.QA
go test ./...intools/docs-version-syncpasses, includingTestFindRepoRootcovering.gitas a directory,.gitas a worktree file, and the not-found case. Verifiedgo run -C tools/docs-version-sync . --target mainnow runs from a nested directory.Issues
Closes #549
Summary by CodeRabbit
Bug Fixes
Tests
Documentation