feat(icms): Import ICMS Service and enable Bazel - #573
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 647 files, which is 347 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (647)
You can disable this status message by setting the Use the checkbox below for a quick retry:
|
harshm98
force-pushed
the
feat/instance-cluster-management-bazel
branch
from
July 30, 2026 14:42
3a883a5 to
1fd008c
Compare
balajinvda
approved these changes
Jul 30, 2026
balajinvda
left a comment
balajinvda
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Please wait for Sanjay's review too.
sanjay-saxena
left a comment
sanjay-saxena
left a comment
Contributor
There was a problem hiding this comment.
Let's get OSRB approval for ICMS dependencies using the ticket. Also, squash all the commits on your branch. Use -s for signed commits. Update PR description manually to check the DCO checkbox.
harshm98
force-pushed
the
feat/instance-cluster-management-bazel
branch
from
July 31, 2026 07:22
209fdb0 to
efd9fb1
Compare
Import the Instance and Cluster Management Service (ICMS) into the monorepo under src/control-plane-services/instance-cluster-management and build it natively with Bazel alongside the other Java control-plane services. - Add icms-core and icms-service Bazel targets, wiring the service against the in-repo nv-boot source libraries. - Register the new Maven coordinates in MODULE.bazel and refresh the pinned lockfile. - Build the release container with java_oci_image and guard the runtime contract with java_image_contract_test, matching cloud-tasks. - Generate the NOTICE and OSRB dependency delta through nvcf_notice and nvcf_notice_delta, and refresh dependencies.md and license-compliance.md. - Register the service for Bazel Java CI discovery. Signed-off-by: Harshawardhan Myana <hmyana@nvidia.com>
sanjay-saxena
force-pushed
the
feat/instance-cluster-management-bazel
branch
from
July 31, 2026 23:13
efd9fb1 to
9b76d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Import the OSS/self-hosted Instance Cluster Management Service (ICMS) into
src/control-plane-services/instance-cluster-managementand enable it as a root-module Bazel Java service alongsidecloud-tasksandnotary.Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
@nv_third_party_depsMaven lockfile, root Bazel metadata, and descriptor-driven Bazel GitHub Actions workflow viabazel-java-ci.json.NOTICE, runtime inventory metadata, and license-grouped OSRB dependency delta using the monorepo-native process.For the Reviewer
Please pay particular attention to:
src/control-plane-services/instance-cluster-management/BUILD.bazelsrc/control-plane-services/instance-cluster-management/icms-core/BUILD.bazelsrc/control-plane-services/instance-cluster-management/icms-service/BUILD.bazelMODULE.bazelandmaven_install.jsonsrc/control-plane-services/instance-cluster-management/bazel-java-ci.jsonNOTICEandnotice_metadata.jsonFor QA
Validated on Java 25:
icms-coretests pass with JUnit and JaCoCo outputs.icms-servicetests pass with JUnit and JaCoCo outputs.Issues
Closes #497
Checklist