Skip to content

feat(self-managed): advance nvcf-api helm chart to 1.23.11 - #601

Open
shelleyshen-0 wants to merge 1 commit into
mainfrom
feat/self-managed/bump-nvcf-api-1.23.11
Open

feat(self-managed): advance nvcf-api helm chart to 1.23.11#601
shelleyshen-0 wants to merge 1 commit into
mainfrom
feat/self-managed/bump-nvcf-api-1.23.11

Conversation

@shelleyshen-0

@shelleyshen-0 shelleyshen-0 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Advance the nvcf-api helm chart in the self-managed stack from 1.23.9 to 1.23.11.

Additional Details

This change tracks two upstream releases from nvcf-api-colocated-deploy:

  • Chart 1.23.10: upgrades the nvcf-api app from 1.9.0-hotfix.1 to 1.12.1
  • Chart 1.23.11: upgrades the nvcf-api app from 1.12.1 to 1.12.6

Latest change in 1.12.6: makes maxFunctionsAllowed and maxTasksAllowed at account creation configurable via AccountLimitsProperties (nvcf.account.max-functions-allowed / nvcf.account.max-tasks-allowed). Self-hosted deployments default to no effective cap (Integer.MAX_VALUE)

For the Reviewer

Single line change in deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl.

For QA

QA is needed to validate the new nvcf-api version in a self-managed environment.

Issues

NVBug: 6510568
NO-REF

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@shelleyshen-0
shelleyshen-0 requested a review from a team as a code owner July 31, 2026 18:42
@shelleyshen-0
shelleyshen-0 requested a review from vrv3814 July 31, 2026 18:42
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The self-managed Helmfile updates the api release chart from version 1.23.9 to 1.23.11.

Changes

API chart update

Layer / File(s) Summary
Update API chart version
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
The api release now uses chart version 1.23.11.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: released

Suggested reviewers: sbaum1994

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses valid Conventional Commits syntax and accurately describes the Helm chart upgrade.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/self-managed/bump-nvcf-api-1.23.11

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl`:
- Line 59: Add repository-native Helmfile render or upgrade validation covering
the helm-nvcf-api chart at version 1.23.11, and record self-managed QA results
confirming API readiness and dependent-service startup. If automation cannot be
added, document the omission and rationale in the Pull Request description.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6292d41b-609b-47e3-9aa2-2e3555b10f09

📥 Commits

Reviewing files that changed from the base of the PR and between 399964b and 8fad047.

📒 Files selected for processing (1)
  • deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl

Comment thread deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
@shelleyshen-0 shelleyshen-0 self-assigned this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant