feat(self-managed): advance nvcf-api helm chart to 1.23.11 - #601
Open
shelleyshen-0 wants to merge 1 commit into
Open
feat(self-managed): advance nvcf-api helm chart to 1.23.11#601shelleyshen-0 wants to merge 1 commit into
shelleyshen-0 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe self-managed Helmfile updates the ChangesAPI chart update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl`:
- Line 59: Add repository-native Helmfile render or upgrade validation covering
the helm-nvcf-api chart at version 1.23.11, and record self-managed QA results
confirming API readiness and dependent-service startup. If automation cannot be
added, document the omission and rationale in the Pull Request description.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6292d41b-609b-47e3-9aa2-2e3555b10f09
📒 Files selected for processing (1)
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Advance the
nvcf-apihelm chart in the self-managed stack from1.23.9to1.23.11.Additional Details
This change tracks two upstream releases from
nvcf-api-colocated-deploy:1.23.10: upgrades thenvcf-apiapp from1.9.0-hotfix.1to1.12.11.23.11: upgrades thenvcf-apiapp from1.12.1to1.12.6Latest change in
1.12.6: makesmaxFunctionsAllowedandmaxTasksAllowedat account creation configurable viaAccountLimitsProperties(nvcf.account.max-functions-allowed/nvcf.account.max-tasks-allowed). Self-hosted deployments default to no effective cap (Integer.MAX_VALUE)For the Reviewer
Single line change in
deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl.For QA
QA is needed to validate the new nvcf-api version in a self-managed environment.
Issues
NVBug: 6510568
NO-REF
Checklist