Skip to content

feat(grpc-proxy): expose GET /info endpoint - #610

Draft
priyaselvaganesan wants to merge 1 commit into
mainfrom
feat/version-endpoint-grpc-proxy
Draft

feat(grpc-proxy): expose GET /info endpoint#610
priyaselvaganesan wants to merge 1 commit into
mainfrom
feat/version-endpoint-grpc-proxy

Conversation

@priyaselvaganesan

Copy link
Copy Markdown
Contributor

TL;DR

Adds GET /info to the grpc-proxy management HTTP server (port 10081, alongside /health), serving service name, version, and commit SHA via go-lib's shared nvcfversion.Handler().

Additional Details

  • Fields come from Service/Version/GitHash x_defs injected at build time (--stamp); GitHash uses {STABLE_GIT_COMMIT_FULL} so commit is the full 40-char SHA. The three go-lib x_defs are added to the existing nvcf-grpc-proxy_lib map (the existing proxy.version x_def is kept).
  • Extracts the mux construction into newProxyMux so the routes are unit-testable. / and /health behavior is unchanged.
  • net/http ServeMux passes all methods to the handler, which returns 405 (Allow: GET) on non-GET.
  • go-lib is a new dependency here, so MODULE.bazel gains the use_repo entry plus the gazelle_override used by other go-lib consumers.

Changes: proxy/h2.go, proxy/info_test.go, proxy/BUILD.bazel, BUILD.bazel (x_defs), tools/workspace_status.sh, MODULE.bazel, go.mod/go.sum.

For QA

Built with bazel build //:image.tar --stamp; confirmed the binary embeds nvcf-grpc-proxy and the full commit SHA. Endpoint behavior is covered by unit tests (GET -> 200 JSON; non-GET -> 405 + Allow: GET + empty body).

For the Reviewer

Issues

Relates to #315

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Dependencies

Pins go-lib to the merged v0.0.0-20260728185909-afca4ec2fb26. Per Go MVS this pulls go.opentelemetry.io/otel to v1.44 and related golang.org/x deps forward, as go-lib requires.

Signed-off-by: priyaselvaganesan <pselvaganesa@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0845e298-a16a-4e4f-a52b-7475a8208be9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant