feat(grpc-proxy): expose GET /info endpoint - #610
Draft
priyaselvaganesan wants to merge 1 commit into
Draft
Conversation
Signed-off-by: priyaselvaganesan <pselvaganesa@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds
GET /infoto the grpc-proxy management HTTP server (port 10081, alongside/health), serving service name, version, and commit SHA via go-lib's sharednvcfversion.Handler().Additional Details
Service/Version/GitHashx_defsinjected at build time (--stamp);GitHashuses{STABLE_GIT_COMMIT_FULL}socommitis the full 40-char SHA. The three go-lib x_defs are added to the existingnvcf-grpc-proxy_libmap (the existingproxy.versionx_def is kept).newProxyMuxso the routes are unit-testable./and/healthbehavior is unchanged.ServeMuxpasses all methods to the handler, which returns405(Allow: GET) on non-GET.MODULE.bazelgains theuse_repoentry plus thegazelle_overrideused by other go-lib consumers.Changes:
proxy/h2.go,proxy/info_test.go,proxy/BUILD.bazel,BUILD.bazel(x_defs),tools/workspace_status.sh,MODULE.bazel,go.mod/go.sum.For QA
Built with
bazel build //:image.tar --stamp; confirmed the binary embedsnvcf-grpc-proxyand the full commit SHA. Endpoint behavior is covered by unit tests (GET -> 200 JSON; non-GET -> 405 + Allow: GET + empty body).For the Reviewer
nvcfversion.Handler())GET /infoendpoint #275 (same pattern), ratelimiter feat(ratelimiter): expose GET /info endpoint #591 (sibling)Issues
Relates to #315
Checklist
Dependencies
Pins go-lib to the merged
v0.0.0-20260728185909-afca4ec2fb26. Per Go MVS this pullsgo.opentelemetry.io/otelto v1.44 and relatedgolang.org/xdeps forward, as go-lib requires.