Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/angular/src/lib/nativescript-renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,22 +274,34 @@ class NativeScriptRenderer implements Renderer2 {
if (NativeScriptDebug.enabled) {
NativeScriptDebug.rendererLog(`NativeScriptRenderer.selectRootElement: ${selectorOrNode}`);
}
// Angular 21+ reads `rootElement.tagName.toLowerCase()` after this call
// (`locateHostElement`) to reject `<script>` hosts. Guarantee every return
// path produces a View with a non-empty string `tagName`; otherwise the
// bootstrap throws `Cannot read properties of undefined (reading 'toLowerCase')`.
const ensureTagName = (view: any, fallback: string) => {
if (view && typeof view.tagName !== 'string') {
try {
view.tagName = view.nodeName || fallback || 'view';
} catch {}
}
return view;
};
if (selectorOrNode instanceof View) {
return selectorOrNode;
return ensureTagName(selectorOrNode, '');
}
if (selectorOrNode && selectorOrNode[0] === '#') {
const result = getViewById(this.rootView, selectorOrNode.slice(1));
return (result || this.rootView) as View;
return ensureTagName((result || this.rootView) as View, selectorOrNode);
}
if (typeof selectorOrNode === 'string') {
const view = this.viewUtil.createView(selectorOrNode);
if (getFirstNativeLikeView(view) === view) {
// view is nativelike!
this.appendChild(this.rootView, view);
return view;
return ensureTagName(view, selectorOrNode);
}
}
return this.rootView;
return ensureTagName(this.rootView, '');
}
parentNode(node: NgView) {
if (NativeScriptDebug.enabled) {
Expand Down
6 changes: 6 additions & 0 deletions packages/angular/src/lib/view-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,12 @@ export class ViewUtil {

const ngView = view as NgView;
ngView.nodeName = name;
// Angular 21+ reads `rootElement.tagName.toLowerCase()` during component bootstrap
// (`locateHostElement`) to reject `<script>` host elements. Native Views have no
// intrinsic `tagName`, so without this assignment the boot throws
// `Cannot read properties of undefined (reading 'toLowerCase')`. Mirror DOM
// conventions where `tagName` equals `nodeName` for element nodes.
ngView.tagName = name;
ngView.meta = getViewMeta(name);

// we're setting the node type of the view
Expand Down
2 changes: 2 additions & 0 deletions packages/angular/src/lib/views/invisible-nodes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export abstract class InvisibleNode extends View implements NgView {
meta: { skipAddToDom: boolean };
nodeType: number;
nodeName: string;
tagName: string;
// @ts-expect-error setter
parentNode: NgView;
nextSibling: NgView;
Expand All @@ -20,6 +21,7 @@ export abstract class InvisibleNode extends View implements NgView {

this.nodeType = 1;
this.nodeName = getClassName(this);
this.tagName = this.nodeName;
}

toString() {
Expand Down
1 change: 1 addition & 0 deletions packages/angular/src/lib/views/view-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface ViewExtensions {
meta: ViewClassMeta;
nodeType: number;
nodeName: string;
tagName: string;
parentNode: NgView;
nextSibling: NgView;
previousSibling: NgView;
Expand Down