Add structured feedback for investigation open questions#22
Merged
Neokil merged 8 commits intoJun 9, 2026
Merged
Conversation
Neokil
commented
May 18, 2026
Neokil
left a comment
Neokil
left a comment
Owner
Author
There was a problem hiding this comment.
This change fails the e2e tests and also it causes an infinite reload loop
Neokil
force-pushed
the
gh-5-add-per-question-feedback-fields-for-investigation-open-questions
branch
from
116cdfc to
aa2d77e
Compare
Neokil
force-pushed
the
gh-5-add-per-question-feedback-fields-for-investigation-open-questions
branch
from
38cfb9c to
9365600
Compare
Cleanup was gated on `isRunning || busy`. `isRunning` is derived from
`activeJobId` which has an unfixable race: for jobs that complete before
the HTTP 202 response returns (pure state transitions like Accept), all
SSE events arrive before `queueAction` can set `activeJobId`, so it
never gets set and never gets cleared.
`busy` is server-authoritative and reliably cleared by `ticket_updated`
events, so use only `busy` for cleanupDisabled.
Also clear `activeJobId` eagerly when `ticket_updated` arrives with a
non-running status, so action buttons unblock without waiting for
`job{done}`.
Neokil
deleted the
gh-5-add-per-question-feedback-fields-for-investigation-open-questions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open Questionslists from the current actionable artifactTesting
Notes
golangci-lint runstill reports existing repository issues in generated code and sibling.auto-pr/worktrees, which are unrelated to this ticket.Closes #5