Develop#87
Open
sedv8808 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions-based deployment pipeline for the Neotoma Explorer static site to S3/CloudFront, and aligns the S3 sync script’s self-exclude filename with the script’s actual name.
Changes:
- Fixes the
aws s3 syncexclude entry inpush_s3.shto excludepush_s3.sh(notpushs3.sh). - Adds a new
.github/workflows/deploy.ymlworkflow that deploys to S3, performs a basic verification, invalidates CloudFront, and attempts rollback on failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| push_s3.sh | Corrects the script filename in the sync exclude list. |
| .github/workflows/deploy.yml | Adds automated deploy/backup/verify/invalidate/rollback steps for S3 + CloudFront on branch pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+6
| on: | ||
| push: | ||
| branches: [production, develop] | ||
|
|
Comment on lines
+17
to
+19
| deploy: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 |
Comment on lines
+42
to
+50
| - name: Verify S3 content | ||
| run: | | ||
| HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" "https://${{ env.CLOUDFRONT_ALIAS }}/explorer/index.html") | ||
| if [ "$HTTP_CODE" = "200" ]; then | ||
| echo "Verification passed (HTTP $HTTP_CODE)" | ||
| else | ||
| echo "WARNING: Got HTTP $HTTP_CODE from explorer" | ||
| exit 1 | ||
| fi |
| @@ -1,2 +1,2 @@ | |||
| #!/bin/bash | |||
| aws s3 sync . s3://apps.neotomadb.org/explorer/ --exclude '.git/*' --exclude pushs3.sh | |||
| aws s3 sync . s3://apps.neotomadb.org/explorer/ --exclude '.git/*' --exclude push_s3.sh | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow for automated deployment and makes a minor correction to the deployment script. The workflow handles deploying the Neotoma Explorer to AWS S3 and CloudFront, including backup, rollback, and cache invalidation steps.
Deployment automation:
.github/workflows/deploy.ymlto automate deployment to AWS S3 and CloudFront, including backup of existing content, verification, cache invalidation, rollback on failure, and deployment status notification.Script correction:
push_s3.shto correctly exclude thepush_s3.shfile during the S3 sync operation.