Update All-Inkl (kas) DNS plugin to certbot-dns-kas ~=1.0#5637
Open
mobilandi wants to merge 4 commits into
Open
Update All-Inkl (kas) DNS plugin to certbot-dns-kas ~=1.0#5637mobilandi wants to merge 4 commits into
mobilandi wants to merge 4 commits into
Conversation
|
Docker Image for build 3 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the bundled All-Inkl (
kas) DNS plugin fromcertbot-dns-kas ~=0.1.1to
~=1.0and drops the now-unnecessarykasserverdependency.Why
certbot-dns-kas1.0.0 is a ground-up rewrite that talks to the All-Inkl KASAPI directly (only
requests; no morekasserver/zeep/lxml). The pinned~=0.1.1is what NPM users currently get, and it has several bugs that 1.0.0fixes:
example.com+*.example.com) now work —0.1.x overwrote the shared
_acme-challengeTXT record, so validation failed..or.at,.co.uk,.com.au, …) now resolvethe correct zone — 0.1.x assumed the last two labels and failed with
zone_not_found._acme-challengeTXT records left behind).Because the rewrite no longer uses
kasserver, thedependenciesfield iscleared (this also drops the heavy
zeep/lxmlchain).Closes #1106, closes #2178
This also addresses the root cause behind #5349 (already closed): the bundled
0.1.x plugin failed on wildcard+apex certificates and on multi-label TLDs such
as .or.at. certbot-dns-kas 1.0.0 fixes both.
Notes
certbot >= 2.0and Python>= 3.9, both satisfied by current NPMimages.
and clean teardown.
Type of Change
AI Usage