Clarify (draft) PRs in contributing guidelines. - #541
Open
nkoukpaizan wants to merge 4 commits into
Open
Conversation
nkoukpaizan
marked this pull request as ready for review
August 14, 2026 18:12
pelesh
approved these changes
Aug 14, 2026
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I added a couple of suggestions. Feel free to include or ignore.
Collaborator
|
Perhaps also add something like "If you don't need CI when pushing your changes to a pull request, please make sure you add |
Co-authored-by: pelesh <peless@ornl.gov>
Co-authored-by: pelesh <peless@ornl.gov>
Collaborator
Author
|
@lukelowry @abirchfield @PhilipFackler @superwhiskers @abdourahmanbarry @alexander-novo @Steven-Roberts @isatkaus, FYI. I'll leave this open until after our next coordination meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This clarifies the use of draft PRs and PR expectations. This is only updates the contributing guidelines and the pull request template (minor change).
Closes #210