Skip to content

Clarify (draft) PRs in contributing guidelines. - #541

Open
nkoukpaizan wants to merge 4 commits into
developfrom
nicholson/contributing-guidelines
Open

Clarify (draft) PRs in contributing guidelines.#541
nkoukpaizan wants to merge 4 commits into
developfrom
nicholson/contributing-guidelines

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Description

This clarifies the use of draft PRs and PR expectations. This is only updates the contributing guidelines and the pull request template (minor change).

Closes #210

@nkoukpaizan nkoukpaizan self-assigned this Aug 14, 2026
@nkoukpaizan nkoukpaizan added documentation Improvements or additions to documentation development Features/Tools related to development of GridKit, rather than use as a library. labels Aug 14, 2026
@nkoukpaizan
nkoukpaizan marked this pull request as ready for review August 14, 2026 18:12

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a couple of suggestions. Feel free to include or ignore.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
@pelesh

pelesh commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Perhaps also add something like "If you don't need CI when pushing your changes to a pull request, please make sure you add [skip ci] in the commit message.

nkoukpaizan and others added 3 commits August 14, 2026 18:29
@nkoukpaizan

Copy link
Copy Markdown
Collaborator Author

@lukelowry @abirchfield @PhilipFackler @superwhiskers @abdourahmanbarry @alexander-novo @Steven-Roberts @isatkaus, FYI. I'll leave this open until after our next coordination meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Features/Tools related to development of GridKit, rather than use as a library. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer guidelines should be updated for draft PR usage

2 participants