[hadamard-hip] Use type-dependant tolerance for validation#277
Open
maarquitos14 wants to merge 1 commit into
Open
[hadamard-hip] Use type-dependant tolerance for validation#277maarquitos14 wants to merge 1 commit into
maarquitos14 wants to merge 1 commit into
Conversation
Collaborator
|
Are there validation errors for "gfx90a -O3" in your test ? I ran the program on gfx90a and gfx942 devices and did not see errors. I assume this is a compiler issue instead of a benchmark issue. Am I right ? Thanks. |
Contributor
Author
|
I'm observing the issue on gfx90a using -O1, both for __half, at hidden dimension 512 and 32768. See output below. If we look closer at the mismatch, for both it's exactly 1 ULP, which is the minimum difference we can find for a given format. However, the current tolerance is lower than 1 ULP for these two cases, so it fails validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current tolerance is too restrictive for smaller types like
halfor__hip_bfloat16, causing validation errors for some optimization sets --e.g. gfx90a -O1. The current patch makes the tolerance type dependant, so the smaller types are more lenient, while the bigger types are still quite restrictive.