Add XDG support for metadata directory#255
Open
lb803 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
References
Additional information
This addresses an issue where offlineimap did not automatically evaluate XDG conventions for the metadata directory location.
While users could manually specify XDG paths in the config file, the code never proactively checked them. Following the existing pattern from init.py (lines 216-229), we now check for XDG_DATA_HOME before falling back to ~/.offlineimap.
The implementation follows a light touch approach: XDG locations are evaluated first, but users can still override via configuration. No XDG enforcement is added. Patch includes unit tests: baseline, regression and new feature coverage.