Local semver#681
Conversation
mcarans
left a comment
There was a problem hiding this comment.
Thanks for looking into this. It's a step in the right direction. See my comments for some requested changes
|
appimage and flatpak built although haven't tested: https://github.com/OoliteProject/oolite/actions/runs/27862543606/job/82460880582 nsis didn't. |
|
Builder is correct when built through CI in appimage. Need to check flatpak and Windows. |
|
Windows build doesn't install gitversion! That explains why it fails. |
|
@oocube You had mentioned the complexity of the build process. I agree it's a problem and I think I will expand this PR to simplify it. I think it is necessary to get all the builds working reliably and will make maintenance and debugging much easier in future. Currently, most builds go through the The version will also be passed to meson as an option instead of calling Can you have a look at #680? I will need to merge those changes to the meson build into this PR. |
|
If the build process can be simplified we ought to go for it. Making massive changes in PRs targeting distinct improvements is not a good way in my eyes. That dilutes the purpose, and we have no chance to accept one change without the other. Rather let's fix what we tried to fix here and run a separate PR for other improvements. |
Flatpak working locally with correct version in game but wrong version in package manager
|
Flatpak works. Windows packages build - have not tried to run them yet. Only release job fails. |
|
The version can be parsed from appimage artifact packageinfo in release job. Will look into that tomorrow: eg. |

Fixes #676 by introducing semver to local builds and adding the BUILDER environment variable.