fix(local-asr): 本地 Qwen3 模型在云端 provider 下误标「当前使用」#794
Open
bigsongeth wants to merge 2 commits into
Open
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 982e377)Here are some key observations to aid the review process:
|
Contributor
|
Persistent review updated to latest commit 982e377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
macOS 本地 Qwen3 模型列表里,即使当前用的是云端 ASR(火山 / 百炼),0.6B 模型仍被误标「当前使用」。
修复 / 新增 / 改进
ModelRow的isActive原本只判settings.activeModel === model.id——那只是本地引擎内部「选中的模型」(默认qwen3-asr-0.6b),不代表整体在用本地 ASR。改为同时判prefs?.activeAsrProvider === 'local-qwen3',与 foundry / sherpa / apple 三处的activeAsrProvider判定对齐。兼容
测试计划
tsc(npm run build)→ 通过(对beta基线)。PR Type
Bug fix
Description
Fix local Qwen3 model "currently using" badge when cloud ASR provider active
Add check for prefs.activeAsrProvider === "local-qwen3" in ModelRow isActive logic
Also sync prefs when setting active model to ensure consistency
Diagram Walkthrough
flowchart LR A["ModelRow isActive"] --> B{Old: settings.activeModel === model.id} A --> C{New: settings.activeModel === model.id AND prefs.activeAsrProvider === 'local-qwen3'} B --> D["Badge shown even with cloud ASR"] C --> E["Badge only when local ASR active"]File Walkthrough
index.tsx
Fix active badge logic for local modelsopenless-all/app/src/pages/LocalAsr/index.tsx
in sync