Skip to content

fix(local-asr): 本地 Qwen3 模型在云端 provider 下误标「当前使用」#794

Open
bigsongeth wants to merge 2 commits into
Open-Less:betafrom
bigsongeth:fix/local-asr-active-badge
Open

fix(local-asr): 本地 Qwen3 模型在云端 provider 下误标「当前使用」#794
bigsongeth wants to merge 2 commits into
Open-Less:betafrom
bigsongeth:fix/local-asr-active-badge

Conversation

@bigsongeth

@bigsongeth bigsongeth commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

User description

摘要

macOS 本地 Qwen3 模型列表里,即使当前用的是云端 ASR(火山 / 百炼),0.6B 模型仍被误标「当前使用」。

修复 / 新增 / 改进

  • ModelRowisActive 原本只判 settings.activeModel === model.id——那只是本地引擎内部「选中的模型」(默认 qwen3-asr-0.6b),不代表整体在用本地 ASR。改为同时判 prefs?.activeAsrProvider === 'local-qwen3',与 foundry / sherpa / apple 三处的 activeAsrProvider 判定对齐。

兼容

  • 纯前端显示条件收紧,无数据 / 行为 / 凭据影响。

测试计划

  • 平台:macOS。ASR 选云端 provider(火山 / 百炼)→「高级 → 本地模型」→ 0.6B 不再显示「当前使用」;切回 local-qwen3 → 徽标恢复。手测通过。
  • 前端 tsc(npm run build)→ 通过(对 beta 基线)。

PR Type

Bug fix


Description

  • Fix local Qwen3 model "currently using" badge when cloud ASR provider active

  • Add check for prefs.activeAsrProvider === "local-qwen3" in ModelRow isActive logic

  • Also sync prefs when setting active model to ensure consistency


Diagram Walkthrough

flowchart LR
  A["ModelRow isActive"] --> B{Old: settings.activeModel === model.id}
  A --> C{New: settings.activeModel === model.id AND prefs.activeAsrProvider === 'local-qwen3'}
  B --> D["Badge shown even with cloud ASR"]
  C --> E["Badge only when local ASR active"]
Loading

File Walkthrough

Relevant files
Bug fix
index.tsx
Fix active badge logic for local models                                   

openless-all/app/src/pages/LocalAsr/index.tsx

  • Updated ModelRow isActive prop to also check prefs.activeAsrProvider
  • Added prefs update in handleSetActiveModel to keep activeAsrProvider
    in sync
  • Fixed mislabeling bug when cloud ASR provider is active
+19/-1   

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 982e377)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 982e377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants